Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor target placement #101

Merged
merged 14 commits into from
Sep 6, 2023
Merged

Refactor target placement #101

merged 14 commits into from
Sep 6, 2023

Commits on Aug 28, 2023

  1. refactor(stimuli): mask_targets() 

    to standardize logic of indicating elements of gratings etc. as targets, which is a big par of the `stimuli`
Also allows for negative element indices, counting backwards from the highest element index

Closes #12
    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9232891 View commit details
    Browse the repository at this point in the history

  2. refactor(stimuli): place_targets() 

    actually places targets in stimulus-dict
    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    fff6f14 View commit details
    Browse the repository at this point in the history

  3. refactor(pinwheels): integrate mask_targets()

    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c748706 View commit details
    Browse the repository at this point in the history

  4. refactor(rings): use place_targets() in rings_generalized()

    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    2da1b65 View commit details
    Browse the repository at this point in the history

  5. feat(stimuli): rings.circular_generalized

    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7e0cf7c View commit details
    Browse the repository at this point in the history

  6. docs(demos): rings.circular_generalized

    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a19a1c4 View commit details
    Browse the repository at this point in the history

  7. feat(stimuli): bullseyes.circular_generalized

    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8b9ad10 View commit details
    Browse the repository at this point in the history

  8. docs(demos): bullseyes.circular_generalized

    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    25669ca View commit details
    Browse the repository at this point in the history

  9. refactor: target_indices defaults to (), but can handle None 

    Closes #97 #98
    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9e8d136 View commit details
    Browse the repository at this point in the history

  10. refactor(waves): integrate place_targets()

    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    daf6acd View commit details
    Browse the repository at this point in the history

  11. refactor(whites): use mask_targets()

    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1e04f07 View commit details
    Browse the repository at this point in the history

  12. refactor(papers): update to use 1-based indexing of elements

    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    bd90b8e View commit details
    Browse the repository at this point in the history

  13. refactor(papers): update to use 1-based indexing of elements in Whites

    @JorisVincent
    JorisVincent committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e1c3101 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. chore: (auto)format

    @JorisVincent
    JorisVincent committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    dea6b57 View commit details
    Browse the repository at this point in the history