Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Node.from_parent constructor when available #152

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

takluyver
Copy link
Member

Fixes compatibility with pytest >=6.

Closes gh-139

@takluyver
Copy link
Member Author

takluyver commented Jul 29, 2020

I've copied the hasattr check from pytest's docs, so we support older versions of pytest. I don't know if from_parent was available before the alternative was deprecated, but the deprecation was in 5.4, released March 2020.

@mattwthompson
Copy link

Just stopping by to say this fixes the issues I've run into with pytest 6+ today (now that it's released and pulled in by default in a lot of builds)

@vidartf vidartf merged commit bf53ad9 into computationalmodelling:master Jul 30, 2020
@vidartf
Copy link
Collaborator

vidartf commented Jul 30, 2020

I'll do a patch release.

@vidartf
Copy link
Collaborator

vidartf commented Jul 30, 2020

Released as 0.9.6

@takluyver
Copy link
Member Author

Thanks Vidar :-)

@vidartf
Copy link
Collaborator

vidartf commented Jul 30, 2020

Thanks for the PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprication warnings from Pytest
4 participants