CP-1062 eslint, karma-jspm #101
Conversation
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "rules": { | |||
| "indent": [ | |||
There was a problem hiding this comment.
can you make this the default 4 space indent (more consistent with other OSS JS repos from our org)?
|
Done |
| ['catch'](function(e) { | ||
| throw e; | ||
| }); | ||
| ['catch'](function(e) { |
There was a problem hiding this comment.
this chunk still looks like 2 space indents
|
@valotas This pull request has merge conflicts, please resolve. |
…slint Conflicts: src/adapter.js src/init.js
|
@valotas This pull request has merge conflicts, please resolve. |
|
@valotas , If we intend on moving ahead with this, can you resolve the merge conflicts? |
|
@dustinlessard-wf I almost forgot that. I fixed the conflicts last time, but I don't feel like doing it every month or so :). So let me know if you feel like merging it and I'll fix them. |
Conflicts: src/adapter.js src/init.js
|
@evanweible-wf I've merged your pr but there were some remaining warnings that I've fixed. It looks like this PR can be merged now. Thanks a lot for the pr anyway! |
|
+1 |
|
+1 |
|
@jayudey-wf ready for merge |
|
QA Resource Approval: +10
Merging into master. |
Make use of basic eslint rules and fixed warnings