Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-1068 Fixes #104: Module interpreted as global module format #105

Merged
merged 1 commit into from
Oct 15, 2015

Conversation

alexcastillo
Copy link
Contributor

Fixes #104

Error: Module interpreted as global module format, but called System register
Solution: Add support to custom meta in karma-jspm config.

Thanks @larrifax for the help.

@maxwellpeterson-wf
Copy link
Contributor

+1 @trentgrover-wf

@trentgrover-wf
Copy link
Collaborator

+1
@jayudey-wf ready for merge

@alexcastillo
Copy link
Contributor Author

Thanks for the +1 @maxwellpeterson-wf @trentgrover-wf

@jayudey-wf jayudey-wf changed the title Fixes #104: Module interpreted as global module format CP-1068 Fixes #104: Module interpreted as global module format Oct 15, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction (provided by Max Peterson)
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • installed into project that consumes karma-jspm and commands were still working as expected
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Oct 15, 2015
CP-1068 Fixes #104: Module interpreted as global module format
@jayudey-wf jayudey-wf merged commit 4a3dd4b into computmaxer:master Oct 15, 2015
@alexcastillo
Copy link
Contributor Author

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants