Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] clippy warnings #230

Merged
merged 1 commit into from
Jul 28, 2022
Merged

[chore] clippy warnings #230

merged 1 commit into from
Jul 28, 2022

Conversation

icepuma
Copy link
Member

@icepuma icepuma commented Jul 28, 2022

Not using the PR template, as this is a cleanup

- use https://crates.io/crates/pretty-assertions
  - gets rid of "bool_assert_comparison" clippy warnings
  - add prettier assertions
- enhanced "check.sh" to also cover tests for clippy warnings
@codecov-commenter
Copy link

Codecov Report

Merging #230 (417fdb5) into main (24183f6) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   46.10%   46.07%   -0.03%     
==========================================
  Files          69       69              
  Lines        2180     2179       -1     
==========================================
- Hits         1005     1004       -1     
  Misses       1175     1175              
Impacted Files Coverage Δ
lib/src/actions/package/providers/dnf.rs 58.02% <ø> (-0.52%) ⬇️
lib/src/actions/user/providers/mod.rs 0.00% <0.00%> (ø)
lib/src/atoms/command/exec.rs 48.48% <ø> (ø)
lib/src/atoms/directory/create.rs 82.60% <ø> (ø)
lib/src/atoms/file/chmod.rs 73.07% <ø> (ø)
lib/src/atoms/file/chown.rs 64.15% <ø> (ø)
lib/src/atoms/file/contents.rs 67.85% <ø> (ø)
lib/src/atoms/file/copy.rs 78.04% <ø> (ø)
lib/src/atoms/file/create.rs 75.00% <ø> (ø)
lib/src/atoms/file/decrypt.rs 87.09% <ø> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24183f6...417fdb5. Read the comment docs.

@icepuma icepuma merged commit 7df204c into comtrya:main Jul 28, 2022
@icepuma icepuma deleted the clippy branch July 28, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants