Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: side effect system #322

Merged
merged 2 commits into from
Mar 27, 2023
Merged

feat: side effect system #322

merged 2 commits into from
Mar 27, 2023

Conversation

icepuma
Copy link
Member

@icepuma icepuma commented Mar 20, 2023

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the motivation / use case for changing the behavior?

The PR adds the first implementation of our side-effect system.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage: 67.93% and project coverage change: +0.17 🎉

Comparison is base (60bf7e9) 44.79% compared to head (bafaa66) 44.96%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   44.79%   44.96%   +0.17%     
==========================================
  Files          82       82              
  Lines        2902     2942      +40     
==========================================
+ Hits         1300     1323      +23     
- Misses       1602     1619      +17     
Impacted Files Coverage Δ
app/src/commands/apply.rs 0.00% <0.00%> (ø)
lib/src/actions/group/providers/macos.rs 0.00% <0.00%> (ø)
lib/src/actions/group/providers/mod.rs 25.00% <ø> (ø)
lib/src/actions/user/providers/macos.rs 0.00% <0.00%> (ø)
lib/src/actions/user/providers/mod.rs 25.00% <ø> (ø)
lib/src/atoms/command/exec.rs 45.71% <0.00%> (-1.35%) ⬇️
lib/src/atoms/mod.rs 13.33% <0.00%> (-2.06%) ⬇️
lib/src/atoms/file/chown.rs 62.29% <57.89%> (-2.52%) ⬇️
lib/src/atoms/file/contents.rs 65.62% <63.63%> (-2.24%) ⬇️
lib/src/atoms/file/link.rs 58.53% <66.66%> (+0.20%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@icepuma icepuma marked this pull request as ready for review March 26, 2023 23:18
@icepuma icepuma requested review from a team, rawkode and martintc and removed request for a team March 26, 2023 23:18
Copy link
Member

@martintc martintc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icepuma icepuma merged commit a92abf2 into comtrya:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants