Add exclude_kwargs to memoization decorators
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eh, said that blocked by joblib. I wonder if we should have own memoization implementation and then not pull joblib dependency at all... but I haven't looked inside joblib yet to assess if it is not-trivial enough to not want to reimplement/support. |
jwodder
force-pushed
the
exclude-kwargs
branch
3 times, most recently
from
8963dd8
to
52b1f0f
Compare
jwodder
force-pushed
the
exclude-kwargs
branch
from
52b1f0f
to
96e703e
Compare
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 93.06% 93.02% -0.05%
==========================================
Files 3 3
Lines 404 430 +26
Branches 49 52 +3
==========================================
+ Hits 376 400 +24
- Misses 17 18 +1
- Partials 11 12 +1
Continue to review full report at Codecov.
|
jwodder
force-pushed
the
exclude-kwargs
branch
from
96e703e
to
e72cdf1
Compare
Conflicts upon rebase: src/fscacher/cache.py - imports + near memoize_path signature - mimiced order like in memoize src/fscacher/tests/test_cache.py - trivial -- keep both added tests
yarikoptic
force-pushed
the
exclude-kwargs
branch
from
3be202c
to
9f0cd2c
Compare
|
was alerted to this one of the oldest outstanding PRs. Rebased, pushed, added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of implementing dandi/dandi-cli#400.
Blocked by joblib/joblib#1164 (edit by @yarikoptic: already closed and likely released)