Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait & retry on rate limit errors for GitHub requests #126

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 9, 2021

Closes #125.

@jwodder jwodder added the patch Increment the patch version when merged label Jul 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2021

Codecov Report

Merging #126 (e0c2700) into master (dc7aa53) will increase coverage by 0.88%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   71.33%   72.21%   +0.88%     
==========================================
  Files          10       10              
  Lines         928      961      +33     
  Branches      140      142       +2     
==========================================
+ Hits          662      694      +32     
- Misses        213      214       +1     
  Partials       53       53              
Impacted Files Coverage Δ
src/tinuous/base.py 86.25% <38.46%> (-1.93%) ⬇️
src/tinuous/util.py 85.86% <50.00%> (-0.80%) ⬇️
src/tinuous/github.py 55.50% <72.50%> (+5.74%) ⬆️
src/tinuous/travis.py 66.36% <0.00%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc7aa53...e0c2700. Read the comment docs.

@jwodder
Copy link
Member Author

jwodder commented Jul 9, 2021

The test failure is because the version of git-annex in Ubuntu's repositories is too old for DataLad. #127 fixes that.

"Request to %s returned %d; waiting & retrying", url, r.status_code
)
i += 1
sleep(i)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This week result in up to about 50 sec sleep total with 10 retries. May be square it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Jul 9, 2021
@yarikoptic
Copy link
Member

since no other pending PRs, let's just release. Thank you @jwodder!

@yarikoptic yarikoptic merged commit 1e6c566 into master Jul 9, 2021
@yarikoptic yarikoptic deleted the gh-125 branch July 9, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

one more spot to wait/retry?
3 participants