-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait & retry on rate limit errors for GitHub requests #126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 71.33% 72.21% +0.88%
==========================================
Files 10 10
Lines 928 961 +33
Branches 140 142 +2
==========================================
+ Hits 662 694 +32
- Misses 213 214 +1
Partials 53 53
Continue to review full report at Codecov.
|
The test failure is because the version of git-annex in Ubuntu's repositories is too old for DataLad. #127 fixes that. |
src/tinuous/base.py
Outdated
"Request to %s returned %d; waiting & retrying", url, r.status_code | ||
) | ||
i += 1 | ||
sleep(i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This week result in up to about 50 sec sleep total with 10 retries. May be square it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
since no other pending PRs, let's just release. Thank you @jwodder! |
Closes #125.