Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix: Custom placeholders don't have to be defined in order any more #99

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 11, 2021

No description provided.

@jwodder jwodder added the documentation Changes only affect the documentation label Jun 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #99 (ea7c9a7) into master (b4f1a5e) will decrease coverage by 2.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   72.95%   70.76%   -2.20%     
==========================================
  Files           9        9              
  Lines         821      821              
  Branches      121      121              
==========================================
- Hits          599      581      -18     
- Misses        179      197      +18     
  Partials       43       43              
Impacted Files Coverage Δ
src/tinuous/__main__.py 48.87% <0.00%> (-9.78%) ⬇️
src/tinuous/github.py 54.59% <0.00%> (-2.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f1a5e...ea7c9a7. Read the comment docs.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be true if you say so. I wonder what weighs happen in case of a circular use though - will we fail gracefully or provide arbitrary result or crash with infinite recursion? ;-)

@jwodder
Copy link
Member Author

jwodder commented Jun 11, 2021

@yarikoptic Crash with infinite recursion.

@yarikoptic
Copy link
Member

@yarikoptic Crash with infinite recursion.

good, in that much better than "arbitrary result" ;)

@jwodder jwodder merged commit 7b695f9 into master Jun 11, 2021
@jwodder jwodder deleted the docfix01 branch June 11, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants