Pixman: Supply cpu-features-path meson option. Required to build for Android-armv7 #24375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: pixman/0.43.4
Motivation
Pixman build for Android armv7 looks for the cpu-features.h header, which usually is supplied by the NDK. Without this patch Pixman does not compile for Android armv7.
Details
Pixman's meson build accepts option which tells it where to look for cpu-features.c and cpu-features.h . This patch does exactly just that.
I am aware of #8011 , but it is not merged, and I assume that Pixman's source code too would need to be patched to take a different library, while my suggested patch just supplies the correct meson option and Pixman just works then.
Even with this patch, older versions of pixman (0.43.0 and 0.42.2) are still build broken for Android armv7, but I am not too concerned with them, because they were buildbroken before this patch too.
Link to a CI run with proposed patch - https://github.com/ViliusSutkus89/conan-odr-index/actions/runs/9563222408
Link to a CI run without proposed patch - https://github.com/ViliusSutkus89/conan-odr-index/actions/runs/9563286270
Note how pixman/0.43.4 - android-armv7 turns green