Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixman: Supply cpu-features-path meson option. Required to build for Android-armv7 #24375

Merged

Conversation

ViliusSutkus89
Copy link
Contributor

Summary

Changes to recipe: pixman/0.43.4

Motivation

Pixman build for Android armv7 looks for the cpu-features.h header, which usually is supplied by the NDK. Without this patch Pixman does not compile for Android armv7.

Details

Pixman's meson build accepts option which tells it where to look for cpu-features.c and cpu-features.h . This patch does exactly just that.

I am aware of #8011 , but it is not merged, and I assume that Pixman's source code too would need to be patched to take a different library, while my suggested patch just supplies the correct meson option and Pixman just works then.

Even with this patch, older versions of pixman (0.43.0 and 0.42.2) are still build broken for Android armv7, but I am not too concerned with them, because they were buildbroken before this patch too.

Link to a CI run with proposed patch - https://github.com/ViliusSutkus89/conan-odr-index/actions/runs/9563222408
Link to a CI run without proposed patch - https://github.com/ViliusSutkus89/conan-odr-index/actions/runs/9563286270
Note how pixman/0.43.4 - android-armv7 turns green


@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@ViliusSutkus89
Copy link
Contributor Author

I'm using conan 2.4.1 . This means the the recipe works on conan v2.

Is this error about required_conan_version = ">=1.53.0" in the conanfile.py?

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (e0efa7d3f84b0456ac39c44953499b442a9a916c):

  • pixman/0.43.4:
    All packages built successfully! (All logs)

  • pixman/0.42.2:
    All packages built successfully! (All logs)

  • pixman/0.43.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (e0efa7d3f84b0456ac39c44953499b442a9a916c):

  • pixman/0.43.4:
    All packages built successfully! (All logs)

  • pixman/0.43.0:
    All packages built successfully! (All logs)

  • pixman/0.42.2:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Jun 19, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for providing the compilation logs, it's of great help!

@ViliusSutkus89
Copy link
Contributor Author

You're welcome. I had to do a CI compile anyways to make sure the patch works, so posting the logs wasn't a big deal

@conan-center-bot conan-center-bot merged commit 4c473a8 into conan-io:master Jun 24, 2024
21 checks passed
ViliusSutkus89 added a commit to ViliusSutkus89/conan-odr-index that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants