Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libavrocpp: add version 1.11.3, compatibility conan v2 #24417

Merged
merged 4 commits into from
Jul 3, 2024
Merged

libavrocpp: add version 1.11.3, compatibility conan v2 #24417

merged 4 commits into from
Jul 3, 2024

Conversation

glywk
Copy link
Contributor

@glywk glywk commented Jun 22, 2024

Summary

Changes to recipe: libavrocpp/1.11.3

Motivation

Add release 1.11.3, bug fix, Conan v2

Details

  • Add release libavroccp/1.11.3
  • Fix conan v2 compatibility
  • Fix minimum c++14 requirement with some components of boost > 1.81.0

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Sign in to view
@glywk glywk mentioned this pull request Jun 22, 2024
Closed
@AbrilRBS AbrilRBS self-assigned this Jun 22, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Jun 23, 2024
Open
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS AbrilRBS mentioned this pull request Jun 24, 2024
Merged
@glywk
Copy link
Contributor Author

glywk commented Jun 24, 2024

Hi, how can I launch again Conan v1/v2 validation pipelines?

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, otherwise looks good :)

recipes/libavrocpp/all/conanfile.py Outdated
Comment on lines 48 to 52
if valid_min_cppstd(self, 14) :
self.requires("boost/[>=1.82.0]", transitive_headers=True)
else:
self.requires("boost/[<1.82.0]", transitive_headers=True)
self.requires("snappy/[~1.1.9]")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we'll need to keep these requirements pinned to a specific version -while we have added some libraries to the list of allowed recipes, boost/snappy are not part of those for now :/

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (c6eaf5bccde4e5a7ecf828cdb1ecea361a90a1e3):

  • libavrocpp/1.11.1:
    All packages built successfully! (All logs)

  • libavrocpp/1.11.3:
    All packages built successfully! (All logs)

  • libavrocpp/1.10.2:
    All packages built successfully! (All logs)

  • libavrocpp/1.11.0:
    All packages built successfully! (All logs)

  • libavrocpp/1.10.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (c6eaf5bccde4e5a7ecf828cdb1ecea361a90a1e3):

  • libavrocpp/1.11.3:
    All packages built successfully! (All logs)

  • libavrocpp/1.11.1:
    All packages built successfully! (All logs)

  • libavrocpp/1.11.0:
    All packages built successfully! (All logs)

  • libavrocpp/1.10.2:
    All packages built successfully! (All logs)

  • libavrocpp/1.10.1:
    All packages built successfully! (All logs)

@glywk
Copy link
Contributor Author

glywk commented Jun 26, 2024

Hi,
As requested, I have replace versions range by only one. Does it miss something else?
Regards

@glywk
Copy link
Contributor Author

glywk commented Jun 27, 2024 •
edited
Loading

Hi, how to get another reviewer to allow to merge this pull request? @toge ?
Regards

@glywk
Copy link
Contributor Author

glywk commented Jul 2, 2024

Hi, I have been added to authorized user but I cannot approve this pull request. Can you help me?
Regards

@AbrilRBS
Copy link
Member

AbrilRBS commented Jul 3, 2024

Hi @glywk, this PR is just waiting for someone from the team to have the time to give an extra review, there's nothing extra you need to do :) Thanks a lot for your patience while we process it!

@conan-center-bot conan-center-bot merged commit 37a1b00 into conan-io:master Jul 3, 2024
28 checks passed
@glywk
Copy link
Contributor Author

glywk commented Jul 3, 2024

Hi @glywk, this PR is just waiting for someone from the team to have the time to give an extra review, there's nothing extra you need to do :) Thanks a lot for your patience while we process it!

Thank you for your explanation and your validation.
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@czoido czoido czoido approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glywk @CLAassistant @conan-center-bot @AbrilRBS @czoido