Add aws-sdk-cpp/1.7.299 recipe #1146

madebr · 2020-03-19T16:29:11Z

Specify library name and version: aws-sdk-cpp/1.7.299

Depends on Add aws-c-event-stream/0.1.4 recipe #1140

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Fixes conan-io/wishlist#145

gocarlos · 2020-03-26T11:11:13Z

related to #621

gocarlos · 2020-06-19T20:48:32Z

@madebr any updates on this?

madebr · 2020-06-20T01:17:51Z

I just pushed a fix to #1140

recipes/aws-sdk-cpp/all/conanfile.py

gocarlos · 2020-06-28T19:44:51Z

CI needs to be re-triggered?

gocarlos · 2020-07-21T09:34:52Z

ping

uilianries · 2020-07-21T14:05:38Z

let's try again

uilianries · 2020-07-21T15:41:38Z

@danimtb something is wrong here, jenkins is hanging, could you please check?

gocarlos · 2020-07-27T08:31:07Z

@danimtb how can we push this forward?

conan-center-bot · 2020-07-27T08:45:40Z

An unexpected error happened and has been reported. Help is on its way! 🏇

gocarlos · 2020-07-27T08:48:01Z

one thing that I think we need to address in the conan center is the process of adding a package:

aws-sdk-cpp adds a release every day!! now as CCI is not automated (yet?) and this recipe is taking months to merge:

I think that now no one is going to use version 1.7.299 as there are already like 100 versions in between!

are there concrete plans to allow people to do the same as npm or cargo does? e.g. upload a package to the CCI by themselfs e.g. when they are upstream?

uilianries · 2020-07-27T14:20:55Z

@gocarlos That's a good point for a further discussion. Usually we include new version when someone asks, for example, Facebook Folly has no releases, so we tag by the date.

danimtb · 2020-07-29T11:36:52Z

@madebr I see the build of this package takes a lot of memory usage in our containers and it gets killed. I suppose aws-sdk-cpp is a huge project. Currently we have a 4 GB limit of memory for runtime processes, could you verify if you are seeing this values as well from your side?

uilianries · 2020-07-29T14:50:08Z

@madebr is mining bitcoins in CCI server 😹

madebr · 2020-07-29T18:14:44Z

@madebr is mining bitcoins in CCI server 😹

@uilianries
You make me thinking. Would it be possible to mine bitcoins at compile time?

The question should be: has anyone done this already? 😺

Croydon · 2020-10-20T21:33:18Z

Please add Fixes https://github.com/conan-io/wishlist/issues/145, thanks!

madebr · 2020-10-21T09:06:59Z

I think it was killed due to out-of-memory.

conan-center-bot · 2020-10-21T10:34:07Z

Some configurations of 'aws-sdk-cpp/1.8.34' failed in build 22 (babeaecb71ab59fa619350c8d1a785c276d3b1d8):

Linux x86_64, Debug, clang 7.0, libc++ . Options: aws-sdk-cpp:shared-True
Access to all the logs

dvirtz

add build_only option to shorten build times

dvirtz · 2020-10-26T11:47:25Z

recipes/aws-sdk-cpp/all/conanfile.py

+        "use_virtual_operations": [True, False],
+        "with_curl": [True, False],
+        "enable_curl_logging": [True, False],
+    }


Suggested change

}

"build_only": "ANY",

}

dvirtz · 2020-10-26T11:47:46Z

recipes/aws-sdk-cpp/all/conanfile.py

+        "use_virtual_operations": True,
+        "with_curl": True,
+        "enable_curl_logging": False,
+    }


Suggested change

}

"build_only": None,

}

dvirtz · 2020-10-26T11:48:32Z

recipes/aws-sdk-cpp/all/conanfile.py

+        self._cmake.definitions["ENABLE_CURL_LOGGING"] = self.options.get_safe("enable_curl_logging")
+        if self.settings.compiler.cppstd:
+            self._cmake.definitions["CPP_STANDARD"] = self._cmake_cpp_standard
+


Suggested change

if self.options.build_only:

self._cmake.definitions["BUILD_ONLY"] = self.options.build_only

dvirtz · 2020-10-29T15:26:56Z

recipes/aws-sdk-cpp/all/conanfile.py

+        cmake = self._configure_cmake()
+        cmake.install()
+
+        tools.rmdir(os.path.join(self.package_folder, "lib", "cmake"))


why delete this? I, as a consumer, prefer the library's cmake config script, if available, rather than conan's generated one

It's cci policy to remove these.
But I agree to your sentiment.
Most cmake config scripts now are relocatable, whereas in the past they had absolute paths to the build systems embedded into them.

@danimtb @uilianries @SpaceIm @jgsogo
aws-sdk-cpp provides a lot of libraries (and config cmake scripts). By a lot, I mean 30+.
conan does currently not provide a way to generate multiple config scripts.
And even then, the generated conan cmake scripts will be generic and never the same as those provided by the aws-sdk-cpp cmake build script.

I feel cci should allow those cmake scripts that play by the book and are fully relocatable.
This would also save a lot of maintenance and acceptance of conan/cci.

It seems that the other AWS packages don't delete this folder, e.g.

conan-center-index/recipes/aws-c-common/all/conanfile.py

Line 85 in 1ad155a

self.cpp_info.components["aws-c-common-lib"].builddirs = [os.path.join("lib", "cmake")]

SpaceIm · 2020-11-04T15:51:09Z

recipes/aws-sdk-cpp/all/conanfile.py

+        if self.settings.compiler.cppstd:
+            tools.check_min_cppstd(self, 2003)


Why 2003? Don't you mean 11 (looking at build())?

I'm wondering myself.
https://github.com/aws/aws-sdk-cpp/blob/2dffafc32c419bc6be45d6345fef0cd50eec3bd3/CMakeLists.txt#L73 says current is 11.

Keep 11. 2003 it's not listed as default cppstd in setting.yml.

I'll make the change to 11.
But 2003 is a fine value too.
Last time I checked, tools.check_min_cppstd converts self.settings.compiler.cppstd and 11 to a 4-digit year,
That way comparing 98 and 11 uses the same code path.

Btw, using 98,11,14,17 and 20 will cause a new y2k-kind problem in less then 80 years. 🤣

SpaceIm · 2020-11-04T15:52:40Z

recipes/aws-sdk-cpp/all/conanfile.py

+    def requirements(self):
+        self.requires("aws-c-common/0.4.25")
+        self.requires("aws-c-event-stream/0.1.5")
+        self.requires("openssl/1.1.1g")


Suggested change

self.requires("openssl/1.1.1g")

self.requires("openssl/1.1.1h")

SpaceIm · 2020-11-04T15:52:49Z

recipes/aws-sdk-cpp/all/conanfile.py

+        self.requires("openssl/1.1.1g")
+        self.requires("zlib/1.2.11")
+        if self.options.with_curl:
+            self.requires("libcurl/7.71.1")


Suggested change

self.requires("libcurl/7.71.1")

self.requires("libcurl/7.73.0")

SpaceIm · 2020-11-04T15:54:27Z

recipes/aws-sdk-cpp/all/conanfile.py

+        for root, _, _ in os.walk(self._source_subfolder):
+            cmakelists = os.path.join(root, "CMakeLists.txt")
+            repl = "AWS::aws-c-event-stream"
+            if os.path.isfile(cmakelists) and repl in tools.load(cmakelists):
+                tools.replace_in_file(cmakelists, repl, "CONAN_PKG::aws-c-event-stream", strict=False)


Shouldn't be required anymore, imported target in aws-c-event-stream recipe was fixed in #2584

dvirtz · 2020-12-01T16:09:42Z

recipes/aws-sdk-cpp/all/conanfile.py

+        tools.rmdir(os.path.join(self.package_folder, "lib", "pkgconfig"))
+
+    def package_info(self):
+        self.cpp_info.libs = tools.collect_libs(self)


as there are inter-dependencies between components (e.g. many depend on aws-sdk-core) it's not good to use collect_libs (see https://docs.conan.io/en/latest/reference/tools.html?highlight=inter%20dependent#tools-collect-libs)

Maybe it needs a similar approach as my boost components pr (#2097)

wow, you have a lot going on

MartinDelille · 2021-01-28T17:42:24Z

Sorry I push a new PR without noticing one was already on its way. Is there something blocking this to be merge ?

ghost · 2021-01-28T18:05:01Z

I detected other pull requests that are modifying aws-sdk-cpp/all recipe:

aws-sdk-cpp/1.8.130 #4401

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

madebr · 2021-01-28T18:30:34Z

@MartinDelille
I haven't worked on this one since months.
It's for you for the taking!

conan-center-bot · 2021-03-07T21:59:02Z

Failure in build 23 (babeaecb71ab59fa619350c8d1a785c276d3b1d8):

aws-sdk-cpp/1.8.34@:
CI failed to create some packages (All logs)

Logs for packageID d644b3a187ced211071d18344ebb6101ba2ab51a:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Debug
compiler=gcc
compiler.libcxx=libstdc++
compiler.version=6
os=Linux
os_build=Linux
[options]
aws-sdk-cpp:shared=False

Scanning dependencies of target aws-cpp-sdk-elastic-inference
[ 34%] Building CXX object source_subfolder/aws-cpp-sdk-elastic-inference/CMakeFiles/aws-cpp-sdk-elastic-inference.dir/ub_ELASTIC-INFERENCE.cpp.o
[ 34%] Linking CXX static library ../../lib/libaws-cpp-sdk-elastic-inference.a
[ 34%] Built target aws-cpp-sdk-elastic-inference
Scanning dependencies of target aws-cpp-sdk-elasticache
[ 35%] Building CXX object source_subfolder/aws-cpp-sdk-elasticache/CMakeFiles/aws-cpp-sdk-elasticache.dir/ub_ELASTICACHE.cpp.o
source_subfolder/aws-cpp-sdk-ec2/CMakeFiles/aws-cpp-sdk-ec2.dir/build.make:82: recipe for target 'source_subfolder/aws-cpp-sdk-ec2/CMakeFiles/aws-cpp-sdk-ec2.dir/ub_EC2.cpp.o' failed
CMakeFiles/Makefile2:6929: recipe for target 'source_subfolder/aws-cpp-sdk-ec2/CMakeFiles/aws-cpp-sdk-ec2.dir/all' failed
[ 35%] Linking CXX static library ../../lib/libaws-cpp-sdk-elasticache.a
[ 35%] Built target aws-cpp-sdk-elasticache
Makefile:148: recipe for target 'all' failed
aws-sdk-cpp/1.8.34: 
fatal: Not a git repository: '/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.34/_/_/build/d644b3a187ced211071d18344ebb6101ba2ab51a/source_subfolder/.git'
CMake Warning at source_subfolder/aws-cpp-sdk-text-to-speech/CMakeLists.txt:31 (message):
  We've detected that you are building on linux, but the header files for
  pulseaudio are not available.  If you are providing your own audio
  implementation or you will not be using the text-to-speech library, this is
  fine.  However, if you are not providing your own implemenation and you
  want to use text-to-speech, you need to install the dev files for
  pulseAudio.  e.g.  apt-get install libpulse-dev or yum install
  pulseaudio-libs-devel.  Currently, no audio implementation will be built
  into this library.


CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY


g++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-6/README.Bugs> for instructions.
make[2]: *** [source_subfolder/aws-cpp-sdk-ec2/CMakeFiles/aws-cpp-sdk-ec2.dir/ub_EC2.cpp.o] Error 4
make[1]: *** [source_subfolder/aws-cpp-sdk-ec2/CMakeFiles/aws-cpp-sdk-ec2.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
WARN: libcurl/7.71.1: requirement openssl/1.1.1j overridden by aws-sdk-cpp/1.8.34 to openssl/1.1.1g 
[HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component aws-c-common::aws-c-common libdir "lib" does not contain any declared library
[HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component aws-checksums::aws-checksums libdir "lib" does not contain any declared library
[HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component openssl::openssl libdir "lib" does not contain any declared library
[HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component aws-c-event-stream::aws-c-event-stream libdir "lib" does not contain any declared library
[HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component libcurl::libcurl libdir "lib" does not contain any declared library
aws-sdk-cpp/1.8.34: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.34/_/_/build/d644b3a187ced211071d18344ebb6101ba2ab51a
aws-sdk-cpp/1.8.34: ERROR: Package 'd644b3a187ced211071d18344ebb6101ba2ab51a' build failed
aws-sdk-cpp/1.8.34: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.34/_/_/build/d644b3a187ced211071d18344ebb6101ba2ab51a
ERROR: aws-sdk-cpp/1.8.34: Error in build() method, line 120
	cmake.build()
	ConanException: Error 2 while executing cmake --build '/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.34/_/_/build/d644b3a187ced211071d18344ebb6101ba2ab51a' '--' '-j2'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Mar 19, 2020

madebr mentioned this pull request Mar 24, 2020

Add arrow/1.0.0 recipe #1182

Merged

4 tasks

This comment has been minimized.

Sign in to view

SpaceIm mentioned this pull request Apr 3, 2020

[request] some of most relevant c++ libraries in github (by number of stars) #621

Open

madebr commented Jun 20, 2020

View reviewed changes

recipes/aws-sdk-cpp/all/conanfile.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

uilianries closed this Jun 29, 2020

uilianries reopened this Jun 29, 2020

uilianries closed this Jul 21, 2020

uilianries reopened this Jul 21, 2020

This comment has been minimized.

Sign in to view

conan-center-bot added the Unexpected Error label Jul 21, 2020

This comment has been minimized.

Sign in to view

madebr force-pushed the aws-sdk-cpp branch from 57601e1 to 7bbd4f6 Compare July 30, 2020 23:49

madebr and others added 8 commits August 25, 2020 17:05

aws-sdk-cpp: fix cmake_find_package{,multi} names

cc18f97

aws-sdk-cpp: bump version of aws-c-event-stream dependency

ff023bc

aws-sdk-cpp: bump version to 1.8.18 + update openssl dependency

42d1b21

aws-sdk-cpp: bump aws-sdk-cpp version to 1.8.19

72523c9

aws-sdk-cpp: bump version of libcurl requirement

1b20a51

aws-sdk-cpp: limit parallelism + short paths on Windows

403a12a

aws-sdk-cpp: bump minimum required cmake version

2474deb

aws-sdk-cpp: bump version to 1.8.34

7abb581

madebr force-pushed the aws-sdk-cpp branch from 39f2c64 to 7abb581 Compare August 25, 2020 15:07

This comment has been minimized.

Sign in to view

aws-sdk-cpp: pass CMAKE_CXX_STANDARD if cppstd undefined

babeaec

This comment has been minimized.

Sign in to view

conan-center-bot removed the Unexpected Error label Oct 20, 2020

dvirtz reviewed Oct 26, 2020

View reviewed changes

dvirtz reviewed Oct 29, 2020

View reviewed changes

SpaceIm reviewed Nov 4, 2020

View reviewed changes

dvirtz reviewed Dec 1, 2020

View reviewed changes

This was referenced Jan 28, 2021

[service] Potentially conflicting recipes #3571

Closed

aws-sdk-cpp/1.8.130 #4401

Merged

conan-center-bot closed this in #4401 Apr 9, 2021


	if self.options.build_only:
	self._cmake.definitions["BUILD_ONLY"] = self.options.build_only

		if self.settings.compiler.cppstd:
		tools.check_min_cppstd(self, 2003)

	self.requires("openssl/1.1.1g")
	self.requires("openssl/1.1.1h")

	self.requires("libcurl/7.71.1")
	self.requires("libcurl/7.73.0")

Add aws-sdk-cpp/1.7.299 recipe #1146

Add aws-sdk-cpp/1.7.299 recipe #1146

Conversation

madebr commented Mar 19, 2020 • edited

This comment has been minimized.

This comment has been minimized.

gocarlos commented Mar 26, 2020

gocarlos commented Jun 19, 2020

madebr commented Jun 20, 2020

This comment has been minimized.

gocarlos commented Jun 28, 2020

gocarlos commented Jul 21, 2020

uilianries commented Jul 21, 2020

This comment has been minimized.

uilianries commented Jul 21, 2020

This comment has been minimized.

This comment has been minimized.

gocarlos commented Jul 27, 2020

conan-center-bot commented Jul 27, 2020

gocarlos commented Jul 27, 2020

uilianries commented Jul 27, 2020

danimtb commented Jul 29, 2020

uilianries commented Jul 29, 2020

madebr commented Jul 29, 2020 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Croydon commented Oct 20, 2020

This comment has been minimized.

madebr commented Oct 21, 2020

conan-center-bot commented Oct 21, 2020

dvirtz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm Nov 4, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madebr Nov 5, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm Nov 4, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MartinDelille commented Jan 28, 2021

ghost commented Jan 28, 2021

madebr commented Jan 28, 2021

conan-center-bot commented Mar 7, 2021

madebr commented Mar 19, 2020 •

edited

madebr commented Jul 29, 2020 •

edited

SpaceIm Nov 4, 2020 •

edited

madebr Nov 5, 2020 •

edited

SpaceIm Nov 4, 2020 •

edited