Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk-cpp/1.8.130 #4401

Merged
merged 73 commits into from
Apr 9, 2021
Merged

Conversation

MartinDelille
Copy link
Contributor

@MartinDelille MartinDelille commented Jan 28, 2021

closes: #1146

Specify library name and version: aws-sdk-cpp/1.8.130

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've tried at least one configuration locally with the
    conan-center hook activated.
  • I've used the latest Conan client version.

@ghost
Copy link

ghost commented Jan 28, 2021

I detected other pull requests that are modifying aws-sdk-cpp/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Jan 28, 2021
5 tasks
recipes/aws-sdk-cpp/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/aws-sdk-cpp/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/aws-sdk-cpp/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/aws-sdk-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/aws-sdk-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/aws-sdk-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/aws-sdk-cpp/all/conanfile.py Show resolved Hide resolved
Comment on lines 233 to 234
if self.settings.compiler == "clang":
libs.append("-stdlib=libstdc++")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use tools.stdcpp_library.
It can be added to the system libs for all os'es and compilers (not only gcc/clang) as:

lib_stdcpp = tools.stdcpp_library(self)
if lib_stdcpp:
    self.cpp_info.system_libs.append(lib_stdcpp)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here: 71ee769

MartinDelille and others added 5 commits January 29, 2021 12:21
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/aws-sdk-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/aws-sdk-cpp/all/conanfile.py Show resolved Hide resolved
recipes/aws-sdk-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/aws-sdk-cpp/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
@conan-center-bot

This comment has been minimized.

@blackliner
Copy link
Contributor

regarding the errors you get: INTERFACE_LIBRARY targets may only have whitelisted properties.

could be that the used CMake version is not new enough? I had something similar, and at that time it was an old cmake version (3.10) that did not yet support all properties on interface libraries. Could be, that the CMAKE_MINIMUM_VERSION of this project is a lie?

@conan-center-bot

This comment has been minimized.

…ion.patch

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@conan-center-bot
Copy link
Collaborator

Failure in build 66 (e4ff14030ccb409f55836fe977deb05885b549b1):

  • aws-sdk-cpp/1.8.130@:
    CI failed to create some packages (All logs)

    Logs for packageID 192bd12380d488f0fedd407ea3601e265fd7da78:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=10
    os=Linux
    os_build=Linux
    [options]
    aws-sdk-cpp:shared=False
    
    -- Found: /home/conan/w/BuildSingleReference/.conan/data/aws-checksums/0.1.5/_/_/package/19729b9559f3ae196cad45cb2b97468ccb75dcd1/lib/libaws-checksums.a
    -- Library aws-c-event-stream found /home/conan/w/BuildSingleReference/.conan/data/aws-c-event-stream/0.1.5/_/_/package/25dd158b5135c61e427a28e8d689f76a2733b1d7/lib/libaws-c-event-stream.a
    -- Found: /home/conan/w/BuildSingleReference/.conan/data/aws-c-event-stream/0.1.5/_/_/package/25dd158b5135c61e427a28e8d689f76a2733b1d7/lib/libaws-c-event-stream.a
    -- Pulse audio header files have been detected, included pulse audio as a possible sound driver implementation.
    -- Configuring done
    -- Generating done
    aws-sdk-cpp/1.8.130: 
    fatal: not a git repository: '/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/192bd12380d488f0fedd407ea3601e265fd7da78/source_subfolder/.git'
    CMake Error at source_subfolder/aws-cpp-sdk-text-to-speech/CMakeLists.txt:108 (add_library):
      Target "aws-cpp-sdk-text-to-speech" links to target "CONAN_PKG::pulseaudio"
      but the target was not found.  Perhaps a find_package() call is missing for
      an IMPORTED target, or an ALIAS target is missing?
    
    
    CMake Error at source_subfolder/aws-cpp-sdk-text-to-speech/CMakeLists.txt:108 (add_library):
      Target "aws-cpp-sdk-text-to-speech" links to target "CONAN_PKG::pulseaudio"
      but the target was not found.  Perhaps a find_package() call is missing for
      an IMPORTED target, or an ALIAS target is missing?
    
    
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    
    
    CMake Generate step failed.  Build files cannot be regenerated correctly.
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component aws-c-common::aws-c-common libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component aws-checksums::aws-checksums libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component libcap::libcap libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component ogg::ogg libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component openssl::openssl libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component opus::opus libdir "lib" does not contain any declared library
    xorg/system: WARN: Lib folder doesn't exist, can't collect libraries: /home/conan/w/BuildSingleReference/.conan/data/xorg/system/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component xorg::xorg libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component aws-c-event-stream::aws-c-event-stream libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component flac::flac libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component libcurl::libcurl libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component vorbis::vorbis libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component vorbis::vorbisenc-alias libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component vorbis::vorbisfile-alias libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component libsndfile::libsndfile libdir "lib" does not contain any declared library
    aws-sdk-cpp/1.8.130: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/192bd12380d488f0fedd407ea3601e265fd7da78
    aws-sdk-cpp/1.8.130: ERROR: Package '192bd12380d488f0fedd407ea3601e265fd7da78' build failed
    aws-sdk-cpp/1.8.130: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/192bd12380d488f0fedd407ea3601e265fd7da78
    ERROR: aws-sdk-cpp/1.8.130: Error in build() method, line 373
    	cmake = self._configure_cmake()
    while calling '_configure_cmake', line 367
    	self._cmake.configure()
    	ConanException: Error 1 while executing cd '/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/192bd12380d488f0fedd407ea3601e265fd7da78' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="10" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++11" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/package/192bd12380d488f0fedd407ea3601e265fd7da78" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCONAN_CMAKE_POSITION_INDEPENDENT_CODE="ON" -DCMAKE_MODULE_PATH="/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/192bd12380d488f0fedd407ea3601e265fd7da78" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DBUILD_ONLY="core;access-management;identity-management;queues;s3-encryption;text-to-speech;transfer" -DBUILD_DEPS="False" -DENABLE_UNITY_BUILD="True" -DENABLE_TESTING="False" -DAUTORUN_UNIT_TESTS="False" -DMINIMIZE_SIZE="False" -Wno-dev '/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/192bd12380d488f0fedd407ea3601e265fd7da78'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot
Copy link
Collaborator

Failure in build 67 (a6dec169a20e05047e1d6d7aceef10ff1c86ecfb):

  • aws-sdk-cpp/1.8.130@:
    CI failed to create some packages (All logs)

    Logs for packageID 2937fbf1973f066e6270ad3da06d84f4b130185d:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=9
    os=Linux
    os_build=Linux
    [options]
    aws-sdk-cpp:shared=False
    
    -- Conan: Using autogenerated Findxorg.cmake
    -- Found xorg: system (found version "system") 
    -- Dependency OpenSSL already found
    -- Pulse audio header files have been detected, included pulse audio as a possible sound driver implementation.
    -- Configuring done
    -- Generating done
    aws-sdk-cpp/1.8.130: 
    fatal: not a git repository: '/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/2937fbf1973f066e6270ad3da06d84f4b130185d/source_subfolder/.git'
    CMake Error at source_subfolder/aws-cpp-sdk-text-to-speech/CMakeLists.txt:109 (add_library):
      Target "aws-cpp-sdk-text-to-speech" links to target "CONAN_PKG::pulseaudio"
      but the target was not found.  Perhaps a find_package() call is missing for
      an IMPORTED target, or an ALIAS target is missing?
    
    
    CMake Error at source_subfolder/aws-cpp-sdk-text-to-speech/CMakeLists.txt:109 (add_library):
      Target "aws-cpp-sdk-text-to-speech" links to target "CONAN_PKG::pulseaudio"
      but the target was not found.  Perhaps a find_package() call is missing for
      an IMPORTED target, or an ALIAS target is missing?
    
    
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    
    
    CMake Generate step failed.  Build files cannot be regenerated correctly.
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component aws-c-common::aws-c-common libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component aws-checksums::aws-checksums libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component libcap::libcap libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component ogg::ogg libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component openssl::openssl libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component opus::opus libdir "lib" does not contain any declared library
    xorg/system: WARN: Lib folder doesn't exist, can't collect libraries: /home/conan/w/BuildSingleReference/.conan/data/xorg/system/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component xorg::xorg libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component aws-c-event-stream::aws-c-event-stream libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component flac::flac libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component libcurl::libcurl libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component vorbis::vorbis libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component vorbis::vorbisenc-alias libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component vorbis::vorbisfile-alias libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component libsndfile::libsndfile libdir "lib" does not contain any declared library
    aws-sdk-cpp/1.8.130: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/2937fbf1973f066e6270ad3da06d84f4b130185d
    aws-sdk-cpp/1.8.130: ERROR: Package '2937fbf1973f066e6270ad3da06d84f4b130185d' build failed
    aws-sdk-cpp/1.8.130: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/2937fbf1973f066e6270ad3da06d84f4b130185d
    ERROR: aws-sdk-cpp/1.8.130: Error in build() method, line 373
    	cmake = self._configure_cmake()
    while calling '_configure_cmake', line 367
    	self._cmake.configure()
    	ConanException: Error 1 while executing cd '/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/2937fbf1973f066e6270ad3da06d84f4b130185d' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="9" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++11" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/package/2937fbf1973f066e6270ad3da06d84f4b130185d" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCONAN_CMAKE_POSITION_INDEPENDENT_CODE="ON" -DCMAKE_MODULE_PATH="/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/2937fbf1973f066e6270ad3da06d84f4b130185d" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DBUILD_ONLY="core;access-management;identity-management;queues;s3-encryption;text-to-speech;transfer" -DBUILD_DEPS="False" -DENABLE_UNITY_BUILD="True" -DENABLE_TESTING="False" -DAUTORUN_UNIT_TESTS="False" -DMINIMIZE_SIZE="False" -Wno-dev '/home/conan/w/BuildSingleReference/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/2937fbf1973f066e6270ad3da06d84f4b130185d'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@jgsogo
Copy link
Contributor

jgsogo commented Apr 2, 2021

I just pushed a modified version of the patch and I have another issue on the conanio/gcc8 docker image which is not related to my modifications:

$ conan create . aws-sdk-cpp/1.8.130@
...
libsndfile/1.0.30: Retrieving package a5a82e5e25d2b15c8664d926968d011b767534dc from remote 'conan-center'
[...]
libxcb-dri3-dev
libxcb-util-dev
xorg/system: ERROR: while executing system_requirements(): Aborted due to CONAN_SYSREQUIRES_MODE=verify. Some system packages need to be installed
ERROR: Error in system requirements

Hi, @MartinDelille , here the CI is using CONAN_SYSREQUIRES_MODE=enabled, so that those system-requirements are being installed. The Conan default is not to install them.

@MartinDelille
Copy link
Contributor Author

Thanks @jgsogo ! It fix my local call to conan create ...

Here is the size on conan/gcc8:

conan@69e599347767:~/.conan/data/aws-sdk-cpp/1.8.130/_/_$ du -hd1 .
28K	./export
522M	./source
4.0K	./locks
574M	./build
28K	./export_source
38M	./package
1.2G	.

I tried deactivating all the options and the result is not so different:

conan@13f07ee58ae4:~/.conan/data/aws-sdk-cpp/1.8.130/_/_$ du -hd1 .
28K	./export
522M	./source
4.0K	./locks
528M	./build
28K	./export_source
3.2M	./package
1.1G	.

The thing is that the code base is huge since most of the code is generated.

@MartinDelille
Copy link
Contributor Author

The build job is still buggy.

@conan-center-bot
Copy link
Collaborator

All green in build 71 (88e557e3f24077c35e90769201b01d0165ac9478):

  • aws-sdk-cpp/1.8.130@:
    All packages built successfully! (All logs)

@MartinDelille
Copy link
Contributor Author

The build is green again! Can't wait to see this PR merge! 😉

Comment on lines +9 to +10
- sort_links(EXPORTS)
+ # sort_links(EXPORTS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this patch, I have the following error:

$ conan create . aws-sdk-cpp/1.8.130@
...
-- Conan: Using autogenerated Findxorg.cmake
-- Found xorg: system (found version "system")
-- Dependency OpenSSL already found
-- Pulse audio header files have been detected, included pulse audio as a possible sound driver implementation.
CMake Error at source_subfolder/cmake/dependencies.cmake:15 (get_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:33 (compute_links)
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


CMake Error at source_subfolder/cmake/dependencies.cmake:20 (set_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:33 (compute_links)
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


CMake Error at source_subfolder/cmake/dependencies.cmake:24 (get_target_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:33 (compute_links)
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


CMake Error at source_subfolder/cmake/dependencies.cmake:34 (get_target_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


CMake Error at source_subfolder/cmake/dependencies.cmake:15 (get_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:33 (compute_links)
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


CMake Error at source_subfolder/cmake/dependencies.cmake:20 (set_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:33 (compute_links)
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


CMake Error at source_subfolder/cmake/dependencies.cmake:24 (get_target_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:33 (compute_links)
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


CMake Error at source_subfolder/cmake/dependencies.cmake:34 (get_target_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


CMake Error at source_subfolder/cmake/dependencies.cmake:15 (get_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:33 (compute_links)
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


CMake Error at CMakeLists.txt:7 (add_subdirectory):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES_ALL" is not allowed.


CMake Error at source_subfolder/cmake/dependencies.cmake:24 (get_target_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:33 (compute_links)
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


CMake Error at source_subfolder/cmake/dependencies.cmake:34 (get_target_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
  source_subfolder/cmake/dependencies.cmake:59 (compute_links)
  source_subfolder/cmake/sdks.cmake:239 (sort_links)
  source_subfolder/CMakeLists.txt:316 (add_sdks)


-- Configuring incomplete, errors occurred!
See also "/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e/CMakeFiles/CMakeOutput.log".
See also "/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e/CMakeFiles/CMakeError.log".
aws-sdk-cpp/1.8.130:
aws-sdk-cpp/1.8.130: ERROR: Package 'd256d3ddc9c58ec327d60900f44081371ed80e6e' build failed
aws-sdk-cpp/1.8.130: WARN: Build folder /home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e
ERROR: aws-sdk-cpp/1.8.130: Error in build() method, line 373
	cmake = self._configure_cmake()
while calling '_configure_cmake', line 367
	self._cmake.configure()
	ConanException: Error 1 while executing cd '/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="8" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/package/d256d3ddc9c58ec327d60900f44081371ed80e6e" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCONAN_CMAKE_POSITION_INDEPENDENT_CODE="ON" -DCMAKE_MODULE_PATH="/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DBUILD_ONLY="core;access-management;identity-management;queues;s3-encryption;text-to-speech;transfer" -DBUILD_DEPS="False" -DENABLE_UNITY_BUILD="True" -DENABLE_TESTING="False" -DAUTORUN_UNIT_TESTS="False" -DMINIMIZE_SIZE="False" -Wno-dev '/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e'

Copy link
Contributor

@SpaceIm SpaceIm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good enough for a first iteration

@prince-chrismc
Copy link
Contributor

Can we please remove the label?

@jgsogo jgsogo removed the infrastructure Waiting on tools or services belonging to the infra label Apr 7, 2021
@conan-center-bot conan-center-bot merged commit fe384ee into conan-io:master Apr 9, 2021
@MartinDelille
Copy link
Contributor Author

Awesome!!! A big thanks to all the people that helped me getting this merged!!! 🎉

@kmaragon
Copy link

kmaragon commented Apr 9, 2021

Thank you @MartinDelille for putting in the massive effort to get this across the finish line.

@MartinDelille
Copy link
Contributor Author

I informed the original repo that a conan recipe exists: aws/aws-sdk-cpp#1613

AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this pull request May 7, 2021
* wip

* Use modification from https://github.com/kmaragon/conan-aws-sdk-cpp

* Update recipes/aws-sdk-cpp/all/test_package/CMakeLists.txt

Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>

* Update recipes/aws-sdk-cpp/all/test_package/conanfile.py

Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>

* Update recipes/aws-sdk-cpp/all/test_package/conanfile.py

Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>

* Apply suggestions from code review

Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>

* Minor formatting fix

* Use cpp_info.libs/system_libs

* Apply suggestions from code review

Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>

* Apply suggestion from blackliner regarding python support

* Improve requirements

* Remove build_ prefix in sdk options

* Fix local recipe on MacOS 10.15

* Update recipes/aws-sdk-cpp/all/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Remove MT compiler runtime for Visual Studio

* Restore python 2 support

This reverts commit ee44846.

* Patch sdks.cmake

* Don't use git for version computing

* Simpler testbucket

* Remove unused code-generation folder

It make Windows copy fail

* Option shared change BUILD_SHARED_LIBS instead of FORCE_SHARED_CRT

* Better shared runtime management for Windows

* Remove aws-cpp-sdk-core-tests folder unused

It contains files with a long path that make copying fails on windows:
aws4_testsuite/post-x-www-form-urlencoded-parameters/post-x-www-form-urlencoded-parameters.*

* Use components

* code-generation contains usefull content

* Don't patch source

* Revert "Don't patch source"

This reverts commit eb65c3e.

* Fix components

* Restore BUILD_ONLY

This reverts commit 749fe9d.

* Drop python2 support

* Disable ec2 sdk

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* build only core by default

Co-authored-by: dvirtz <dvirtz@gmail.com>

* Use libcurl 7.74.0

* Add logs to default_options

* Require openssl/1.1.1j

* Let libcurl manage openssl requirement

* Don't use logs as default option and remove core logging from
example.cpp

* Skip gcc4.9 shared

* Revert "Skip gcc4.9 shared"

This reverts commit c67ccd5.

* Add CMakeLists.txt wrapper

* Skip gcc4.9 shared

This reverts commit e68262d.

* Skip gcc5 shared

* Patch upstream CMakeLists.txt to for lib folder

* Remove cmake_find_package generator

Co-authored-by: Florian Berchtold <florian.berchtold@luminartech.com>

* Revert "Remove cmake_find_package generator"

This reverts commit bfcad0a.

* Use tools.rmdir

* Restore ec2 since it is not build by the CI

* Consistent quote

* topics crossplateform => cross-platform

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Apply suggestions from code review from @SpaceIm

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Remove lib/pkgconfig folder removal

* Patch have .patch extension

* Improve package_info() components (wip)

* Revert "Remove lib/pkgconfig folder removal"

This reverts commit e7fb3d2.

* Apply suggestions from code review

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Disable CMAKE_INSTALL_RPATH_USE_LINK_PATH

* Enable dependant options

* Make sure S3 is automatically add in the test

* Update recipes/aws-sdk-cpp/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Prefix _sdks and _internal_requirements with underscore

* Update recipes/aws-sdk-cpp/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Add system audio libraries

* Update recipes/aws-sdk-cpp/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Update recipes/aws-sdk-cpp/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Improve pulseaudio detection

* Update recipes/aws-sdk-cpp/all/patches/0004-improve-pulseaudio-detection.patch

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Improve pulseaudio detection patch

* Update recipes/aws-sdk-cpp/all/patches/0004-improve-pulseaudio-detection.patch

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

* Restore find_package(pulseaudio)

* Update recipes/aws-sdk-cpp/all/CMakeLists.txt

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: dvirtz <dvirtz@gmail.com>
Co-authored-by: Florian Berchtold <florian.berchtold@luminartech.com>
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@MartinDelille MartinDelille deleted the aws-sdk-cpp branch July 15, 2021 09:05
@MartinDelille MartinDelille restored the aws-sdk-cpp branch September 4, 2021 08:43
@MartinDelille MartinDelille deleted the aws-sdk-cpp branch September 4, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet