-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-sdk-cpp/1.8.130 #4401
aws-sdk-cpp/1.8.130 #4401
Conversation
I detected other pull requests that are modifying aws-sdk-cpp/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
recipes/aws-sdk-cpp/all/conanfile.py
Outdated
if self.settings.compiler == "clang": | ||
libs.append("-stdlib=libstdc++") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use tools.stdcpp_library
.
It can be added to the system libs for all os'es and compilers (not only gcc/clang) as:
lib_stdcpp = tools.stdcpp_library(self)
if lib_stdcpp:
self.cpp_info.system_libs.append(lib_stdcpp)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done here: 71ee769
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
This comment has been minimized.
This comment has been minimized.
regarding the errors you get: could be that the used CMake version is not new enough? I had something similar, and at that time it was an old cmake version (3.10) that did not yet support all properties on interface libraries. Could be, that the CMAKE_MINIMUM_VERSION of this project is a lie? |
This comment has been minimized.
This comment has been minimized.
…ion.patch Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
Failure in build 66 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Failure in build 67 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Hi, @MartinDelille , here the CI is using |
Thanks @jgsogo ! It fix my local call to Here is the size on
I tried deactivating all the options and the result is not so different:
The thing is that the code base is huge since most of the code is generated. |
The build job is still buggy. |
All green in build 71 (
|
The build is green again! Can't wait to see this PR merge! 😉 |
- sort_links(EXPORTS) | ||
+ # sort_links(EXPORTS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this patch, I have the following error:
$ conan create . aws-sdk-cpp/1.8.130@
...
-- Conan: Using autogenerated Findxorg.cmake
-- Found xorg: system (found version "system")
-- Dependency OpenSSL already found
-- Pulse audio header files have been detected, included pulse audio as a possible sound driver implementation.
CMake Error at source_subfolder/cmake/dependencies.cmake:15 (get_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:33 (compute_links)
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
CMake Error at source_subfolder/cmake/dependencies.cmake:20 (set_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:33 (compute_links)
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
CMake Error at source_subfolder/cmake/dependencies.cmake:24 (get_target_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:33 (compute_links)
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
CMake Error at source_subfolder/cmake/dependencies.cmake:34 (get_target_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
CMake Error at source_subfolder/cmake/dependencies.cmake:15 (get_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:33 (compute_links)
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
CMake Error at source_subfolder/cmake/dependencies.cmake:20 (set_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:33 (compute_links)
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
CMake Error at source_subfolder/cmake/dependencies.cmake:24 (get_target_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:33 (compute_links)
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
CMake Error at source_subfolder/cmake/dependencies.cmake:34 (get_target_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
CMake Error at source_subfolder/cmake/dependencies.cmake:15 (get_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:33 (compute_links)
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
CMake Error at CMakeLists.txt:7 (add_subdirectory):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES_ALL" is not allowed.
CMake Error at source_subfolder/cmake/dependencies.cmake:24 (get_target_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:33 (compute_links)
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
CMake Error at source_subfolder/cmake/dependencies.cmake:34 (get_target_property):
INTERFACE_LIBRARY targets may only have whitelisted properties. The
property "LINK_LIBRARIES_ALL" is not allowed.
Call Stack (most recent call first):
source_subfolder/cmake/dependencies.cmake:59 (compute_links)
source_subfolder/cmake/sdks.cmake:239 (sort_links)
source_subfolder/CMakeLists.txt:316 (add_sdks)
-- Configuring incomplete, errors occurred!
See also "/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e/CMakeFiles/CMakeOutput.log".
See also "/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e/CMakeFiles/CMakeError.log".
aws-sdk-cpp/1.8.130:
aws-sdk-cpp/1.8.130: ERROR: Package 'd256d3ddc9c58ec327d60900f44081371ed80e6e' build failed
aws-sdk-cpp/1.8.130: WARN: Build folder /home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e
ERROR: aws-sdk-cpp/1.8.130: Error in build() method, line 373
cmake = self._configure_cmake()
while calling '_configure_cmake', line 367
self._cmake.configure()
ConanException: Error 1 while executing cd '/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="8" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/package/d256d3ddc9c58ec327d60900f44081371ed80e6e" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCONAN_CMAKE_POSITION_INDEPENDENT_CODE="ON" -DCMAKE_MODULE_PATH="/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DBUILD_ONLY="core;access-management;identity-management;queues;s3-encryption;text-to-speech;transfer" -DBUILD_DEPS="False" -DENABLE_UNITY_BUILD="True" -DENABLE_TESTING="False" -DAUTORUN_UNIT_TESTS="False" -DMINIMIZE_SIZE="False" -Wno-dev '/home/conan/.conan/data/aws-sdk-cpp/1.8.130/_/_/build/d256d3ddc9c58ec327d60900f44081371ed80e6e'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's good enough for a first iteration
Can we please remove the label? |
Awesome!!! A big thanks to all the people that helped me getting this merged!!! 🎉 |
Thank you @MartinDelille for putting in the massive effort to get this across the finish line. |
I informed the original repo that a conan recipe exists: aws/aws-sdk-cpp#1613 |
* wip * Use modification from https://github.com/kmaragon/conan-aws-sdk-cpp * Update recipes/aws-sdk-cpp/all/test_package/CMakeLists.txt Co-authored-by: Yoann Potinet <intelligide@hotmail.fr> * Update recipes/aws-sdk-cpp/all/test_package/conanfile.py Co-authored-by: Yoann Potinet <intelligide@hotmail.fr> * Update recipes/aws-sdk-cpp/all/test_package/conanfile.py Co-authored-by: Yoann Potinet <intelligide@hotmail.fr> * Apply suggestions from code review Co-authored-by: Yoann Potinet <intelligide@hotmail.fr> * Minor formatting fix * Use cpp_info.libs/system_libs * Apply suggestions from code review Co-authored-by: Yoann Potinet <intelligide@hotmail.fr> * Apply suggestion from blackliner regarding python support * Improve requirements * Remove build_ prefix in sdk options * Fix local recipe on MacOS 10.15 * Update recipes/aws-sdk-cpp/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Remove MT compiler runtime for Visual Studio * Restore python 2 support This reverts commit ee44846. * Patch sdks.cmake * Don't use git for version computing * Simpler testbucket * Remove unused code-generation folder It make Windows copy fail * Option shared change BUILD_SHARED_LIBS instead of FORCE_SHARED_CRT * Better shared runtime management for Windows * Remove aws-cpp-sdk-core-tests folder unused It contains files with a long path that make copying fails on windows: aws4_testsuite/post-x-www-form-urlencoded-parameters/post-x-www-form-urlencoded-parameters.* * Use components * code-generation contains usefull content * Don't patch source * Revert "Don't patch source" This reverts commit eb65c3e. * Fix components * Restore BUILD_ONLY This reverts commit 749fe9d. * Drop python2 support * Disable ec2 sdk Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * build only core by default Co-authored-by: dvirtz <dvirtz@gmail.com> * Use libcurl 7.74.0 * Add logs to default_options * Require openssl/1.1.1j * Let libcurl manage openssl requirement * Don't use logs as default option and remove core logging from example.cpp * Skip gcc4.9 shared * Revert "Skip gcc4.9 shared" This reverts commit c67ccd5. * Add CMakeLists.txt wrapper * Skip gcc4.9 shared This reverts commit e68262d. * Skip gcc5 shared * Patch upstream CMakeLists.txt to for lib folder * Remove cmake_find_package generator Co-authored-by: Florian Berchtold <florian.berchtold@luminartech.com> * Revert "Remove cmake_find_package generator" This reverts commit bfcad0a. * Use tools.rmdir * Restore ec2 since it is not build by the CI * Consistent quote * topics crossplateform => cross-platform Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Apply suggestions from code review from @SpaceIm Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Remove lib/pkgconfig folder removal * Patch have .patch extension * Improve package_info() components (wip) * Revert "Remove lib/pkgconfig folder removal" This reverts commit e7fb3d2. * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Disable CMAKE_INSTALL_RPATH_USE_LINK_PATH * Enable dependant options * Make sure S3 is automatically add in the test * Update recipes/aws-sdk-cpp/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Prefix _sdks and _internal_requirements with underscore * Update recipes/aws-sdk-cpp/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Add system audio libraries * Update recipes/aws-sdk-cpp/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Update recipes/aws-sdk-cpp/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Improve pulseaudio detection * Update recipes/aws-sdk-cpp/all/patches/0004-improve-pulseaudio-detection.patch Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Improve pulseaudio detection patch * Update recipes/aws-sdk-cpp/all/patches/0004-improve-pulseaudio-detection.patch Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> * Restore find_package(pulseaudio) * Update recipes/aws-sdk-cpp/all/CMakeLists.txt Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: Yoann Potinet <intelligide@hotmail.fr> Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: dvirtz <dvirtz@gmail.com> Co-authored-by: Florian Berchtold <florian.berchtold@luminartech.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
closes: #1146
Specify library name and version: aws-sdk-cpp/1.8.130
conan-center hook activated.