-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openssl] Update test_package for Conan v2 #15801
[openssl] Update test_package for Conan v2 #15801
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
I detected other pull requests that are modifying openssl/1.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think testing the most common way of consumer openssl via CMake should be tested... if we want to use config then it should be a separate test package
@uilianries I personally never liked |
There's no replacement because that distinction no longer exists in v2, with layout the folder structure should be the same regardless and without calling Conan within cmake it should not be required. There's no place to right that though 😕 🤔 |
what exactly do you mean? can we specify in migration guide something like |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
No because there is no intention of keeping that feature. There is no chorus asking to porting to Conan v2, and so far, it's not a popular feature and would increase Conan v2 weight porting something which will not be used. |
Review comments have been addressed
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
* remove in_local_cache Signed-off-by: Uilian Ries <uilianries@gmail.com> * improve test package Signed-off-by: Uilian Ries <uilianries@gmail.com> * do not use cmake package config for testing Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com>
self.in_local_cache
is not available on Conan v2 and should be used only for "Conan Development Flow" which does not fit regular CCI recipes