Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashpad recipe #5511
Crashpad recipe #5511
Changes from all commits
76393f9
72e829c
c3c5344
97da449
86211a0
9f80e66
c33efe3
df147bb
9820f33
b5a2615
d23d8e2
1fadeea
d2d39f8
f97b718
ef8fd4a
7fa8a36
0a59692
5bf6525
0fba308
3f7c73c
91fb3b5
d173ac2
eb7a82a
38c4462
d2859a5
a1f3795
63a61f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Windows there seems to be two executables provided. (missing .com)
https://chromium.googlesource.com/crashpad/crashpad/+/master/doc/overview_design.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in eb7a82a but untested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it. It's called
crashpad_handler_com.com
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come it's called
crashpad_handler_com.com
instead of justcrashpad_handler.com
as according to the documentation?