Add freeimage/3.18.0 #9243
Merged
Add freeimage/3.18.0 #9243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
intelligide
suggested changes
Feb 3, 2022
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
uilianries
previously approved these changes
Feb 9, 2022
There was a problem hiding this comment.
- FreeImage does not have an official cmake file, but it refers the project as FreeImage, so I'm fine accepting it as cmake target
- The upstream offers a Makefile, which didn't work to me at first try with GCC11. So I'm fine accepting this cmake wrapper
- I see a big number of patches, and they are related to external dependencies only, so I'm fine with it.
LGTM
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
All green in build 6 (
|
uilianries
approved these changes
Feb 16, 2022
SSE4
approved these changes
Feb 21, 2022
| components.append("libtiff::libtiff") | ||
| return components | ||
|
|
||
| self.cpp_info.names["pkg_config"] = "freeimage" |
There was a problem hiding this comment.
Missing new generators 🤷
intelligide
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: freeimage/3.18.0
This is a new addition to the ConanCenter.
closes #3027
conan-center hook activated.