Allow a directory as config install source #53
Conversation
Lawrencemm
changed the title
Lawrencemm
changed the title
| }); | ||
| configInstallLocation.getEmptyText().setText("Directory or URL"); |
There was a problem hiding this comment.
| configInstallLocation.getEmptyText().setText("Directory or URL"); | |
| configInstallLocation.getEmptyText().setText("Git repository, local folder or ZIP file (local or http)"); |
Maybe it is too long, but it is what we currently have in the help message
There was a problem hiding this comment.
Looking here: https://docs.conan.io/en/latest/reference/commands/consumer/config.html
We might want to provide a checkbox to add --type git to the config install command.
You can also force the git download by using --type git (in case it is not deduced from the URL automatically):
There was a problem hiding this comment.
The above requires the checkbox to be persisted.
I'm not currently comfotable making changes to the persistency because we don't seem to have any unit tests for it.
I might make an issue for this force_git thing, and come back to it after we have some more robust testing. What do you think?
There was a problem hiding this comment.
Yes, don't worry about that. IMHO all the config should be refactored in the future, t could be better to have a submenu for the configuration populated by [all] the values in .conan/conan.con and .conan/remotes.json and let the user modify them individually (these values would be persisted by Conan itself, not by CLion)... and the download/install button would be just an action, and at that moment it will request a URL/file.
It is a big change, I'm not sure about it, but it would make the integration much better if the user doesn't need to go to the command line to do some modifications.
There was a problem hiding this comment.
The only problem is Conan changing the format of those files. It is easier to parse/write the files than to use json output from CLI interface. We would need to abstract file format and implement reader/writers for different Conan versions.
This is less vague/potentially confusing.
Lawrencemm
force-pushed
the
local_config
branch
from
7a3b3a3
to
42ec914
Compare
|
I noticed that I had a bunch of wrong wordings/inconsistencies in the UI because some things are hard coded in the ConanConfig.form file. It seems neither of us picked up on this so it might be worth making a policy that PRs which affect the UI must provide some screenshots or something, otherwise such mistakes might make it through and be annoying later. Anyway here are some screens as of commit 42ec914:
Failure to install:
Successfully installed:
Note that it says nothing on success. It might be better to give feedback if config install is successful. |
|
One more thing: there should probably be a file picker widget here for locating local files/directories. Let me know if you'd like that included or left to a future enhancement. |
|
Thanks for the screenshots 🙌 I would like to know your opinion about #53 (comment) before thinking about adding other widgets to this UI form (which, by the way, I would leave for the future). |
|
👍 I'm happy |
Closes #23.