-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to properly set CMAKE_MAKE_PROGRAM? #14197
Comments
Hi @AndrewAtAvenza, thanks a lot for your question. You were most of the way there! The conf you're looking for to set in either your profile or your Please try that and let me know if it helps :) |
Wow, thanks for the fast response! I set it in my global.conf like so:
But I'm still getting the same error complaining that
|
BTW, in case it matters, I'm using |
Oh I see the issue, the variable is only being injected if using |
I appreciate it! I should mention that the NDK -- as far as I know -- always includes
it'd be great if there was a way to either have it automatically choose the ninja from the NDK if you select that as the Generator or failing that (which does seem a bit too magical) maybe it could be possible to specify the |
While I figure out the best way forward with the conf I mentioned, heres a workaround for you: In your profile's
(Check here for the path appending syntax) This will ensure that ninja is eventually found by CMake in the path (Thanks @jcar87 for the suggestion!) Another alternative would be to add another As for your suggestion about this being automatically handled, this is something that's totally possible with the right changes to the android-ndk recipe, but one which we would have to properly consider :) |
That workaround did the trick! Thanks! I'm glad it can be made more auto-magical -- it feels more than a bit weird to be using Conan to download the NDK package but then point at the ninja.exe from a different NDK installation! |
Hi @AndrewAtAvenza I've now sent a PR to hopefully get the conf to work for all cases for the next Conan release, thanks a lot for your input. (Adding it to the buildenv profile seems to also be an ok solution from what I can see after discussing it with the team a bit further!) |
Great! Thanks for all the help! I got my first local package built (sqlite, looking for the lowest hanging fruit) and and I'm playing with figuring out how to integrate Conan with our build system. And I look forward to when the |
Great to hear! Feel free to open more issues should you have any other question :) |
@AbrilRBS the problem We need a |
for cmake only variables, you can use the |
This works for almost everything else but |
What is your question?
I'm new to Conan and I'm trying to get a sample package (sqlite) building for Android on my Windows machine. The main problem I'm having is that I cannot figure out how to set the CMAKE_MAKE_PROGRAM environment variable such that Conan picks it up properly and propagates it to CMake.
After a fair bit of tinkering, I've figured out how to get it to work, but I'm 100% sure this is the wrong way to do it:
I know enough about Conan at this point to know that embedding local paths into recipes is a terrible idea. Also while it does build successfully, it fails the test step, which is probably a good thing since it further dissuades anyone from doing this. But how do I set CMAKE_MAKE_PROGRAM properly? I've tried setting it in the profile like this:
But that doesn't seem to have an effect: I just get:
There must be a way to do this, but I cannot find an example anywhere and I'm running out of things to read. What am I doing wrong? Any help would be greatly appreciated!
Thanks!
Have you read the CONTRIBUTING guide?
The text was updated successfully, but these errors were encountered: