-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- move cmake_find_package_multi generator to the top #2269
base: develop
Are you sure you want to change the base?
- move cmake_find_package_multi generator to the top #2269
Conversation
Signed-off-by: SSE4 <tomskside@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would refactor the list completely, something like:
Recommended generators:
* CMakeDeps (default in Conan v2)
* cmake (to be deprecated in v2)
* cmake_find_package_multi (to be deprecated in v2)
* cmake_find_package (to be deprecated in v2)
* ...
Not recommended (already deprecated):
* cmake_paths
* cmakemulti
(And same comments for #2268)
Yes, I agree with marking the current state and the plans for the future. In fact, in my opinion, I would only recommend CMakeDeps that is going to be default for the examples in the documentation... |
Agree with @czoido |
so, to clarify, it should look like:
|
I wouldn't say that |
is it good enough? |
But we recommend it... why we cant? |
I don't see any problem with that - we use and recommends many things that are experimental: even cmake_find_package_multi is marked as experimental... seems like in that aspect, there is no difference between |
We use things that are experimental, yes. We recommend things that are experimental, yes... but we do it in issues, PRs, and slack. We don't write side by side in the documentation: "A will have breaking changes. We recommend you to use A. Any alternative to A is deprecated". IMHO it is not the best message you can send from docs. It leaves you with no alternative if you are considering Conan for anything serious 🤷 . People reading docs (1M page views per month) don't read issues, PRs, or slack. |
if we talk about sources of truths where we recommend things, it's not just docs, but also:
but my main point is that |
Absolutely. I only think docs should be aligned with our message, and our message should be supported by the docs. |
I think I can finally close this with #2878 as it's will have updated the language around both the old and new generators 🤞 |
I think this is still the best idea as it gives you a really quick overview |
for newbies, it's not obvious what should be the reasonable default choice for the cmake generator amongst others:
as we expect (most of) readers to read the documentation from the top to the bottom, IMO it's reasonable to place a default choice to the top rather to the very bottom.