Hook: export metadata #21
Conversation
jgsogo
force-pushed
the
hooks/export_metadata
branch
2 times, most recently
from
73b3c14
to
39fbde1
Compare
|
This will need a merge-rebase from master @jgsogo |
| repo = repo_class(path) | ||
| try: | ||
| kwargs = {} | ||
| if not semver.satisfies(__version__, "<=1.12.x", loose=True): |
There was a problem hiding this comment.
Why not direct comparison using Version class? Is loose necessary?
There was a problem hiding this comment.
Try it a little bit, it was not easy to get a working expression, but I would be very pleased if you suggest something simpler.
There was a problem hiding this comment.
Not sure, but something like this?
| if not semver.satisfies(__version__, "<=1.12.x", loose=True): | |
| if Version(__version__) >= "1.12.0": |
There was a problem hiding this comment.
Version("1.12.0-dev") >= "1.12.0" ❌
There was a problem hiding this comment.
What about... ?
>>> Version("1.12.0-dev") >= "1.12"
True
There was a problem hiding this comment.
It could work, but conans.model.version.Version doesn't belong to the public Conan API 😝
There was a problem hiding this comment.
Still don't know why you are not using the Version class as it is something we are somehow recommending fo recipes...
There was a problem hiding this comment.
There is an open issue about conans.model.Version that is proposing to define an API for that class. The operator >= could dissapear in favor of a satisfies function like in SemVer, and then this hook (production code) will be broken requiring an update from the user... I prefer to rely on public APIs, once it is defined we can change it.
|
I have a use-case for this: I'd like to capture the value of an environment variable at build time (kind of a version number generated on the CI). However, as I expressed elsewhere, the centrally installed nature of hooks makes me uneasy towards using them. I'd much rather have member functions in |
|
Hi @sztomi, first of all, I would be very pleased to know your concerns about the centrally installed nature of hooks, feedback about them in this early stage could be really valuable. Feel free to open a new issue or post it elsewhere, but please share the link, I would want to read it. About your use case, you can have a look at this issue (conan-io/conan#2456) and the ones that are linked to it, I know it is not structured because there are bits of information split into several places, but I think that one solution for those issues (and your use case) is to have a function that will be executed at export time and its result serialized and hardcoded into the recipe file (implementation is not relevant at this stage). That issue is tagged with the |
|
@jgsogo opened a GHI here, see the link above. |
back to original folder
add msg to exception add funtion to remove fallback
jgsogo
force-pushed
the
hooks/export_metadata
branch
from
0aff77f
to
4afd10c
Compare
Built on top of #20
Add a hook to create a
metadata.jsonfile at export time that will be uploaded with the recipe, afterwards it could be queried using theconan getcommand.