Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip post package for static library when building header only #457

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Skip post package for static library when building header only #457

merged 2 commits into from
Nov 24, 2022

Conversation

uilianries
Copy link
Member

  • Post package for header-only is already validated. No artifacts is expected
  • When is a header-only package, ignores shared=False on post package.

fixes #456

/cc @toge

prince-chrismc
prince-chrismc previously approved these changes Nov 23, 2022
View reviewed changes
@uilianries
skip header-only
d12f9a9 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
minimize test
163671e 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@danimtb danimtb merged commit 5f77fdc into conan-io:master Nov 24, 2022
@SpaceIm
Copy link
Contributor

SpaceIm commented Dec 2, 2022

Should this logic also be added to _shared_files_well_managed()?

@SpaceIm
Copy link
Contributor

SpaceIm commented Dec 5, 2022 •
edited
Loading

I think this PR should be reverted.
Hook behaved properly in conan-io/conan-center-index#14330 (#456), miniaudio recipe was not removing shared option in configure() when header_only option was True.

SpaceIm added a commit to SpaceIm/hooks that referenced this pull request Dec 5, 2022
@SpaceIm
Revert "Skip post package for static library when building header only (
da5536e 
conan-io#457)"

This reverts commit 5f77fdc.
@SpaceIm SpaceIm mentioned this pull request Dec 5, 2022
Merged
@prince-chrismc prince-chrismc mentioned this pull request Dec 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@prince-chrismc prince-chrismc Awaiting requested review from prince-chrismc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[conan-center] KB-H0074: False positove when using self.info.clear() as optional
4 participants
@uilianries @SpaceIm @danimtb @prince-chrismc