Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[conan-center] New KB-H077 - test whether shared libs on macOS are relocatable #477

Merged
merged 3 commits into from
Jan 20, 2023
Merged

[conan-center] New KB-H077 - test whether shared libs on macOS are relocatable #477

merged 3 commits into from
Jan 20, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 15, 2023

closes #376

@SpaceIm SpaceIm changed the title [conan-center] New KB-H077 -test whether shared libs on macOS are relocatable [conan-center] New KB-H077 - test whether shared libs on macOS are relocatable Jan 15, 2023
@SpaceIm SpaceIm force-pushed the feat/kb-h077-apple-shared-relocatable branch from 5a9f1e5 to 9e7ddbd Compare January 15, 2023 23:47
uilianries
uilianries previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SpaceIm
SpaceIm commented Jan 16, 2023
View reviewed changes
hooks/conan-center.py Outdated Show resolved Hide resolved
uilianries
uilianries previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 19, 2023 •
edited
Loading

I have this new hook in my conan cache currently, and I've built many conan-center recipes. It works fine so far (no false positive).
For example I've been able to detect that patch allowing to install relocatable shared libs on macOS of latest gtsam version was illformed (it has not been properly written to do what patches of previous versions were doing, because upsteam maintainer has scattered the logic to remove in other files, leading to non-relocatable shared libs, but it's not something reviewers can easily see without this hook).

@uilianries uilianries merged commit 8914d76 into conan-io:master Jan 20, 2023
@SpaceIm SpaceIm deleted the feat/kb-h077-apple-shared-relocatable branch January 20, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[conan-center] Add a hook to check whether installed shared libs are relocatable on Linux & macOS
3 participants
@SpaceIm @uilianries @danimtb