Don't set the conan user if no CONAN_USER is given #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables installing from conan repositories that are not user/password protected.
|
Hey, is there anything I can do to expedite this pull request? |
memsharded
approved these changes
Nov 14, 2022
|
Hi @einoj Sorry, that this wasn't managed, this year we will get to +5000 PRs in our different repos, and it is a real challenge to process all of them. I think the change makes sense, lets merge it, thanks very much for your contribution! |
|
@memsharded can we merge this into the honister branch as well? Happy to submit a PR with the changes, but not sure if you'd prefer to cherry pick or merge this branch again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables installing from conan repositories that are not
user/password protected.