Example App: add delete file example #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#174012764]
@scytacki, the policy defined in functions codebase:
https://github.com/concord-consortium/token-service/blob/master/functions/src/base-resource-object.ts#L389-L418
was already listing delete actions, so no changes and new deployment were necessary there.
However, delete action wasn't working anyway. I had to update the policy attached to token-service-staging IAM role:
https://console.aws.amazon.com/iam/home?region=us-east-1#/roles/token-service-staging (ConcordQA)
using AWS UI. It fixed the delete action.
So, I went ahead and also did the same for production role:
https://console.aws.amazon.com/iam/home?region=us-east-1#/roles/token-service-production
If you open the demo page:
http://token-service.concord.org/branch/delete-file/example-app/index.html
you can create a new file, update, delete, and then update again (there's little delay between delete and update, it seems 404 is cached for a bit). So, that should cover everything that CFM needs.
I didn't work on the commit hash and file filters, as it's a bit separate task (no changes to functions this time), and I'd like to get CFM fixed asap. But I've added a story that I can come back to later: https://www.pivotaltracker.com/story/show/174197199