Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example App: add delete file example #26

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Conversation

pjanik
Copy link
Member

@pjanik pjanik commented Aug 5, 2020

[#174012764]

@scytacki, the policy defined in functions codebase:
https://github.com/concord-consortium/token-service/blob/master/functions/src/base-resource-object.ts#L389-L418
was already listing delete actions, so no changes and new deployment were necessary there.

However, delete action wasn't working anyway. I had to update the policy attached to token-service-staging IAM role:
https://console.aws.amazon.com/iam/home?region=us-east-1#/roles/token-service-staging (ConcordQA)
using AWS UI. It fixed the delete action.

So, I went ahead and also did the same for production role:
https://console.aws.amazon.com/iam/home?region=us-east-1#/roles/token-service-production

If you open the demo page:
http://token-service.concord.org/branch/delete-file/example-app/index.html
you can create a new file, update, delete, and then update again (there's little delay between delete and update, it seems 404 is cached for a bit). So, that should cover everything that CFM needs.

I didn't work on the commit hash and file filters, as it's a bit separate task (no changes to functions this time), and I'd like to get CFM fixed asap. But I've added a story that I can come back to later: https://www.pivotaltracker.com/story/show/174197199

@pjanik pjanik requested a review from scytacki August 5, 2020 16:34
Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@scytacki scytacki merged commit 1ae3384 into master Aug 5, 2020
@scytacki scytacki deleted the 174012764-delete-file branch May 20, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants