Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #5

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Update readme #5

merged 1 commit into from
Apr 9, 2020

Conversation

pjanik
Copy link
Member

@pjanik pjanik commented Apr 7, 2020

Small changes to dev setup, so it's a bit easier for someone who never worked with firebase cli. I've used npm i -g firebase-tools as that's what Firebase CLI docs are recommending. The local installation also updated my package.json files, I think we don't want that.

Small changes to dev setup, so it's a bit easier for someone who never worked with firebase cli. I've used `npm i -g firebase-tools` as that's what Firebase CLI docs are recommending. The local installation also updated my package.json files, I think we don't want that.
@pjanik pjanik requested a review from dougmartin April 7, 2020 17:03
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@pjanik pjanik merged commit 203f153 into master Apr 9, 2020
@scytacki scytacki deleted the pjanik-patch-1 branch May 20, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants