-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
187792765 automation for time series data display #166
187792765 automation for time series data display #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
If you need me to data attributes to anything so you can target them better with Cypress just let me know (or you can add them yourself). See here for more info:
https://docs.cypress.io/guides/references/best-practices#Selecting-Elements
By the way, I decided not to introduce additional data test IDs for this repository. However, if we find the need to do more for MYW in the future, I’d consider going back and cleaning up the code to add data test IDs. I’ll complete the merge once I’ve confirmed the push is working. |
I'll keep the branch open for now in case any more quick tweaks need to be done. If this is more than 60 days old I'd say it's fine to delete. |
PT-187792765
This PR adds Automation for Time Series Data Display:
Regarding the deletion of time series data, I encountered an issue today where the deletion button doesn’t respond to the mouse click in Cypress. I’m not sure why this is happening. I’ll post about it in the QA channel, but I’ve commented out the drafted code for now. Any insights would be appreciated.This has been fixed