Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187792765 automation for time series data display #166

Merged
merged 10 commits into from
Jul 17, 2024

Conversation

nstclair-cc
Copy link
Collaborator

@nstclair-cc nstclair-cc commented Jul 15, 2024

PT-187792765

This PR adds Automation for Time Series Data Display:

  • Creation of time series data with fake sensor data.
  • Ensure elements display correctly.
  • Checks for deletion of time series data.
  • Checks for recording time series data.

Regarding the deletion of time series data, I encountered an issue today where the deletion button doesn’t respond to the mouse click in Cypress. I’m not sure why this is happening. I’ll post about it in the QA channel, but I’ve commented out the drafted code for now. Any insights would be appreciated. This has been fixed

@nstclair-cc nstclair-cc added bug Something isn't working help wanted Extra attention is needed labels Jul 15, 2024
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

If you need me to data attributes to anything so you can target them better with Cypress just let me know (or you can add them yourself). See here for more info:

https://docs.cypress.io/guides/references/best-practices#Selecting-Elements

@nstclair-cc nstclair-cc removed bug Something isn't working help wanted Extra attention is needed labels Jul 17, 2024
@nstclair-cc
Copy link
Collaborator Author

Looks good 👍
Thanks for the review, Doug! John, Saravanan, and I managed to fix the delete data trial issue during the QA standup today, so I’ll proceed with the merge.

By the way, I decided not to introduce additional data test IDs for this repository. However, if we find the need to do more for MYW in the future, I’d consider going back and cleaning up the code to add data test IDs.

I’ll complete the merge once I’ve confirmed the push is working.

@nstclair-cc nstclair-cc merged commit 9cebb35 into master Jul 17, 2024
5 checks passed
@nstclair-cc
Copy link
Collaborator Author

nstclair-cc commented Jul 17, 2024

I'll keep the branch open for now in case any more quick tweaks need to be done. If this is more than 60 days old I'd say it's fine to delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants