Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for broken PDF generated by concord graph script #3

Closed
wants to merge 1 commit into from
Closed

Fix for broken PDF generated by concord graph script #3

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 26, 2015

  • Previous versions of this file were comparing stream metadata objects.
  • This worked fine until grouping options were changed in the getting-started repo.
  • Solution is to only compare names of 'StreamMetadata' objects.
  • Also broke out some logic from 'printdot' into a separate method for clarity.

Fix for broken PDF generate by concord graph script
0d3ef1f 
- Previous versions of this file were comparing stream metadata objects.
- This worked fine until grouping options were changed in the
- getting-started repo.
- Solution is to only compare names of streamMetadata objects.
- Also broke out some logic from printDot into a seperate method for
- clarity.
@ghost ghost closed this Jun 29, 2015
@ghost ghost deleted the bugfix/graph_issues branch August 2, 2016 15:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants