-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Wrap multiple elements using the new picker #5758
Conversation
#12668 Bundle Size — 62.24MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
Current #12668 |
Baseline #12658 |
|
---|---|---|
Initial JS | 45.31MiB (~+0.01% ) |
45.31MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 22.07% |
22.28% |
Chunks | 30 |
30 |
Assets | 33 |
33 |
Modules | 4292 |
4292 |
Duplicate Modules | 521 |
521 |
Duplicate Code | 31.78% |
31.78% |
Packages | 448 |
448 |
Duplicate Packages | 51 |
51 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #12668 |
Baseline #12658 |
|
---|---|---|
JS | 62.23MiB (~+0.01% ) |
62.23MiB |
HTML | 11.16KiB (-0.33% ) |
11.2KiB |
Bundle analysis report Branch feat/wrap-multiple Project dashboard
I've left a message on discord about special casing some wrap behaviors for div, fragment and group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not forget about re adding the special cased wrapping behavior for div, group, fragment
editor/src/components/navigator/navigator-item/component-picker-context-menu.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to avoid those subscripts because they're a bug waiting to happen.
Problem:
Our current picker does not support multiple selections, we need this functionality for wrapping multiple elements
Fix:
Make the new picker accept multiple selections.
Important note: this PR adds the functionality of wrapping multiple elements, but for replacment and inserts the target remains only the first selection (as it was before).
We need to decide later on what to do about insertion/replacements
Monosnap.screencast.2024-05-27.17-26-52.mp4
Manual Tests:
I hereby swear that:
Fixes #5696