When loading component descriptors, take account of file mappings. #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le mappings. - `importedFromWhere` now invokes `applyFilePathMappingsToFilePath` for the path that it returns so that it applies the path mapping rules to the results gained. - Added a call to `getFilePathMappings` in a few places to support a call to `getComponentDescriptorForTarget`.
seanparsons
changed the title
seanparsons
requested review from
gbalint,
balazsbajorics,
benwolfram,
liady and
bkrmendy
#12727 Bundle Size — 62.26MiB (~+0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
|
| Current #12727 |
Baseline #12724 |
|
|---|---|---|
 Initial JS |
45.33MiB(~+0.01%) |
45.33MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
22.1% |
22.52% |
| Chunks |
30 |
30 |
| Assets |
33 |
33 |
| Modules |
4294 |
4294 |
| Duplicate Modules |
521 |
521 |
| Duplicate Code |
31.78% |
31.78% |
| Packages |
448 |
448 |
| Duplicate Packages |
51 |
51 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #12727 |
Baseline #12724 |
|
|---|---|---|
| JS |
62.25MiB (~+0.01%) |
62.25MiB |
| HTML |
11.16KiB (-0.33%) |
11.2KiB |
Bundle analysis report Branch fix/component-annotation-file-ma... Project dashboard
|
Performance test results: |
bkrmendy
approved these changes
May 29, 2024
gbalint
approved these changes
May 31, 2024
ruggi
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If you annotate a component with the full module path as module name (e.g. /app/components/hydrogen/new/Layout), then if it is imported using the short path (e.g. @h2/new/Layout), the component will not be recognized and connected to the annotation.
Fix:
The logic for looking up the component descriptors didn't take account of the mappings found in
jsconfig.json, now it applies the mappings and then does a lookup of the filename.Commit Details:
importedFromWherenow invokesapplyFilePathMappingsToFilePathfor the path that it returns so that it applies the path mapping rules to the results gained.getFilePathMappingsin a few places to support a call togetComponentDescriptorForTarget.Manual Tests:
I hereby swear that:
Fixes #5734