Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aff_iterate() fails on M1 macbooks #186

Closed
jpihlaja-bt opened this issue Dec 9, 2021 · 0 comments · Fixed by #189
Closed

aff_iterate() fails on M1 macbooks #186

jpihlaja-bt opened this issue Dec 9, 2021 · 0 comments · Fixed by #189
Assignees

Comments

@jpihlaja-bt
Copy link
Contributor

The thread_policy_set() call in aff_iterate() fails on my M1 macbook with KERN_NOT_SUPPORTED. The reported error from the regression tests is "Success" as thread_policy_set() doesn't set errno.

jpihlaja-bt added a commit to jpihlaja-bt/ck that referenced this issue Feb 10, 2022
The `thread_policy_set` call in `aff_iterate` fails on with
`KERN_NOT_SUPPORTED`. The reported error from the regression tests
is "Success" as thread_policy_set() doesn't set errno. This patch
converts `KERN_NOT_SUPPORTED` into a successful return, as the
the affinity binding is only advisory in the regression tests.

Fixes concurrencykit#186
jpihlaja-bt added a commit to jpihlaja-bt/ck that referenced this issue Feb 10, 2022
The `thread_policy_set` call in `aff_iterate` fails on with
`KERN_NOT_SUPPORTED` on M1 macbooks. The reported error from the
regression tests is "Success" as `thread_policy_set` doesn't set
errno. This patch converts `KERN_NOT_SUPPORTED` into a successful
return, as the the affinity binding is only advisory in the regression
tests.

Fixes concurrencykit#186
jpihlaja-bt added a commit to jpihlaja-bt/ck that referenced this issue Feb 10, 2022
The `thread_policy_set` call in `aff_iterate` fails on with
`KERN_NOT_SUPPORTED` on M1 macbooks. The reported error from the
regression tests is "Success" as `thread_policy_set` doesn't set
errno. This patch converts `KERN_NOT_SUPPORTED` into a successful
return, as the the affinity binding is only advisory in the regression
tests.

Fixes concurrencykit#186
jpihlaja-bt added a commit to jpihlaja-bt/ck that referenced this issue Feb 10, 2022
The `thread_policy_set` call in `aff_iterate` fails on with
`KERN_NOT_SUPPORTED` on M1 macbooks. The reported error from the
regression tests is "Success" as `thread_policy_set` doesn't set
errno. This patch converts `KERN_NOT_SUPPORTED` into a successful
return, as the the affinity binding is only advisory in the regression
tests, and sets errno to `EINVAL` on other errors.

Fixes concurrencykit#186
jpihlaja-bt added a commit to jpihlaja-bt/ck that referenced this issue Feb 10, 2022
The `thread_policy_set` call in `aff_iterate` fails with
`KERN_NOT_SUPPORTED` on M1 macbooks. The reported error from the
regression tests is "Success" because `thread_policy_set` doesn't set
errno.

This patch converts `KERN_NOT_SUPPORTED` into a successful return and
sets errno to `EINVAL` on other errors.  This is ok in the regression
tests as there affinity binding is only advisory.

Fixes concurrencykit#186
pkhuong pushed a commit that referenced this issue Feb 10, 2022
The `thread_policy_set` call in `aff_iterate` fails with
`KERN_NOT_SUPPORTED` on M1 macbooks. The reported error from the
regression tests is "Success" because `thread_policy_set` doesn't set
errno.

This patch converts `KERN_NOT_SUPPORTED` into a successful return and
sets errno to `EINVAL` on other errors.  This is ok in the regression
tests as there affinity binding is only advisory.

Fixes #186
jpihlaja-bt added a commit to jpihlaja-bt/ck that referenced this issue Feb 11, 2022
Didn't build everything from scratch when fixing concurrencykit#186 and missed
that errno.h wasn't included on mach.
pkhuong pushed a commit that referenced this issue Feb 11, 2022
Didn't build everything from scratch when fixing #186 and missed
that errno.h wasn't included on mach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant