aff_iterate() fails on M1 macbooks #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `thread_policy_set` call in `aff_iterate` fails with `KERN_NOT_SUPPORTED` on M1 macbooks. The reported error from the regression tests is "Success" because `thread_policy_set` doesn't set errno. This patch converts `KERN_NOT_SUPPORTED` into a successful return and sets errno to `EINVAL` on other errors. This is ok in the regression tests as there affinity binding is only advisory. Fixes concurrencykit#186
jpihlaja-bt
force-pushed
the
ref/heads/jpihlaja/186/aff_iterate-on-m1
branch
from
a44fd54
to
63bc921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
thread_policy_setcall inaff_iteratefails on withKERN_NOT_SUPPORTEDon M1 macbooks. The reported error from theregression tests is "Success" as
thread_policy_setdoesn't seterrno. This patch converts
KERN_NOT_SUPPORTEDinto a successfulreturn, as the the affinity binding is only advisory in the regression
tests, and sets errno to
EINVALon other errors.Fixes #186