Add core members to heroku and anaconda #904
Conversation
|
@conda-forge/core, thoughts on this? I might add other things like |
|
Definitely a good idea. I'd be happier if we moved this to a private a repo so we don't accidentally merge a random PR without thinking. We could use one of the ones we already have. |
|
Thanks Isuru! 🙏 Agree this is a good idea Matt's point also sounds reasonable |
|
Thinking about this more. Would it make sense to add this info to |
|
I don't follow that last comment @jakirkham. However I am ok with the checks just added by @isuruf. We should add one more check that the only files modified are adding the yaml and then I'd be ok merging. This way we'll have a backup if someone attempts to modify the scripts to remove the check for core members. |
|
Meaning that we would include our DockerHub, Quay, and Heroku handles in |
|
|
||
|
|
||
| def _get_core(url): | ||
| res = requests.get(url) |
There was a problem hiding this comment.
| res = requests.get(url) | |
| res = requests.get(url) |
| res = requests.get(url) | |
| res = requests.get(url) | |
| res.raise_for_status() |
|
|
||
| def _get_core(url): | ||
| res = requests.get(url) | ||
| data = csv.reader(res.content.decode("utf-8").splitlines(), delimiter=',') |
There was a problem hiding this comment.
This can be .text, I think?
| data = csv.reader(res.content.decode("utf-8").splitlines(), delimiter=',') | |
| data = csv.reader(res.text.splitlines(), delimiter=',') |
| return _get_core(f"{URL_BASE}/core.csv") | _get_core(f"{URL_BASE}/emeritus.csv") | ||
|
|
||
|
|
||
| def check(request): |
There was a problem hiding this comment.
Should we run check() as part of run() too?
|
Going to use this in a private repo. See #906 |
Guidelines for marking packages as broken:
instead of marking packages as broken. This alternative workflow makes environments more reproducible.
not technically broken and should not be marked as such.
but should be patched in the repo data and be marked unbroken later.
the maintainers only, we can allow packages to be marked broken more liberally.
conda-forge/core) try to make a decision on these requests within 24 hours.What will happen when a package is marked broken?
brokenlabel to the package. Themainlabel will remain on the package and this is normal.anaconda.orgCDN picks up the new patches, you will no longer be able to install the package from themainchannel.Checklist:
I want to mark a package as broken (or not broken):
I want to archive a feedstock:
I want to request (or revoke) access to an opt-in CI resource: