Update recipe for atom 0.4.0

[MatthieuDartiailh]

No description provided.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[MatthieuDartiailh]

@blink1073 sorry to bother but I am really puzzled by the Python 3.6 error related to SIZE_MAX not being defined. This is definitively outside Atom and I don't really know what I can do about it.

[blink1073]

@jakirkham, have you seen this before? It looks like pyport.h is using SIZE_MAX, but for some reason it is not defined in Python 3.6.

[jakirkham]

@conda-forge-admin, please rerender.

[jakirkham]

Can't say I have. Though this SO answer looks promising.

[jakirkham]

Should add that stdint.h defines SIZE_MAX and that is included by inttypes.h, which pyport.h includes. So it is a little strange not to see SIZE_MAX defined here.

[jakirkham]

Just for fun, restarted CircleCI to see if this is a persistent issue.

[MatthieuDartiailh]

The recipe was re-rendered (first commit conda-smithy 2.4.2) and the error appears to be persistent. I just checked that updating conda and conda-smithy did not change the recipe. What else can I try ?

[jakirkham]

Yeah I missed that initially. Normally make that a separate commit (e.g. conda-smithy rerender -c). Though I don't think re-rendering or conda and friends are the issue. Have you tried the SO answer linked above?

[MatthieuDartiailh]

I am not sure how to pass those arguments through setuptools, but I will check. What also surprises me is that the build works fine on travis (https://travis-ci.org/nucleic/atom/jobs/286633059). Can it be something with the image Circle CI is using ?

[jakirkham]

Would actually try setting the CFLAGS environment variable or similar to include them.

[MatthieuDartiailh]

Thanks will try.

[jakirkham]

Sorry clicked comment too soon.

Can it be something with the image Circle CI is using ?

I don't think so. After all it builds fine for Python 3.5 and 2.7.

@blink1073 had a good idea by wondering if it was Python version specific. It may turn out to be relevant even if we haven't figured out exactly how. For instance, we did release 3.6.3 not that long ago. So maybe 3.6.2 doesn't have this problem. Could change python in build to python <3.6.3 for instance to force 3.6.2.

[MatthieuDartiailh]

Tried to set the CFLAGS, no luck there

[jakirkham]

Sorry I must be missing it. Where did you set CFLAGS? I see the movement to build scripts, but not the environment variable being set. 😕

[MatthieuDartiailh]

Actually my mistake sorry for the noise

[MatthieuDartiailh]

The CFLAGS did the trick apparently

[blink1073]

Looks good! 🍻

[MatthieuDartiailh]

Thanks for the help @jakirkham and @blink1073. If Travis come back green feel free to merge.

[jakirkham]

Might be worth adding the SO answer link in a comment above in case anyone wonders why this is here. Included the short link below.

ref: https://stackoverflow.com/a/30472875

[jakirkham]

No problem, @MatthieuDartiailh. Glad to help. :)