Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use conda-forge-metadata for feedstock-outputs #233

Merged
merged 4 commits into from
May 5, 2023

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Apr 14, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Needs:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jaimergp jaimergp marked this pull request as ready for review May 5, 2023 10:47
@jaimergp jaimergp requested a review from a team as a code owner May 5, 2023 10:47
@jaimergp
Copy link
Member Author

jaimergp commented May 5, 2023

I am running into a bit of a bootstrapping problem (hence the edits in the scripts/workflows), but other than that this is ready for review @conda-forge/core!

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the logic is the same. If we cannot find an output then we assume things are ok.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh ignore me I cannot read.

@beckermr beckermr merged commit b5921ec into conda-forge:main May 5, 2023
@beckermr
Copy link
Member

beckermr commented May 5, 2023

Oh woops we needed to bump the version in the recipe.

@jaimergp jaimergp mentioned this pull request May 5, 2023
5 tasks
@jaimergp
Copy link
Member Author

jaimergp commented May 5, 2023

Oh woops we needed to bump the version in the recipe.

See #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants