Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overly strict versions #47

Closed
isuruf opened this issue Apr 26, 2018 · 6 comments · Fixed by #52
Closed

Fix overly strict versions #47

isuruf opened this issue Apr 26, 2018 · 6 comments · Fixed by #52

Comments

@isuruf
Copy link
Member

isuruf commented Apr 26, 2018 •
edited
Loading

curl 7.44 should be changed to 7 and max_pin: x
@jakirkham
Copy link
Member

So effectively this would make the pinning something like curl >=7.59,<8 (7.59 is latest in c-f), right? This should resolve issue ( conda-forge/cmake-feedstock#53 ) then.

cc @stuarteberg

@isuruf
Copy link
Member Author

isuruf commented Apr 26, 2018

Yes.

@jakirkham jakirkham mentioned this issue Apr 26, 2018
Closed
@isuruf
Copy link
Member Author

isuruf commented Apr 26, 2018

There are more packages like fontconfig, bzip2, ffmpeg that should be fixed.

@jakirkham
Copy link
Member

bzip2 is probably not worth thinking about too hard. There haven't been releases of it in almost a decade.

Agree with the others that we can relax them a bit.

@jakirkham
Copy link
Member

Also libpng and libtiff.

ref: https://abi-laboratory.pro/tracker/timeline/libpng/
ref: https://abi-laboratory.pro/tracker/timeline/libtiff/

@jakirkham jakirkham changed the title Fix curl version Fix overly strict versions Apr 28, 2018
@jakirkham
Copy link
Member

Took the liberty of renaming the issue to be a bit more general as I had trouble finding it. Hope that is ok. Feel free to tweak it further as needed.

@isuruf isuruf mentioned this issue Apr 29, 2018
Merged
1 task
This was referenced May 1, 2018
Merged
Merged
maresb pushed a commit to maresb/conda-forge-pinning-feedstock that referenced this issue Nov 1, 2022
@mariusvniekerk
Merge pull request conda-forge#47 from isuruf/re2_pin
442983a 
Fix re2 pin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Looser pins isuruf/conda-forge-pinning-feedstock
2 participants
@jakirkham @isuruf