Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing run_exports in cuda-cupti-dev #10

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Mar 22, 2024

Fix #9

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from a team as a code owner March 22, 2024 16:20
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this looks like an oversight on our part. Thanks!

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

As a note: I double-checked the SONAME / version compatibility of cupti. Prior to CUDA 12, linking to libcupti would break CUDA Enhanced Compatibility (runtime compatibility within the same major version) because it required the same major.minor version of CUDA. It seems that restriction has been lifted in CUDA 12.0 and later. That would've meant we needed different compatibility rules here but I think we are all good.

@vyasr
Copy link
Contributor

vyasr commented Mar 26, 2024

We're doing a bit more investigation here as to whether there are issues with CEC in the rest of the dependency tree here.

@vyasr
Copy link
Contributor

vyasr commented Mar 26, 2024

There are some subtleties around usage of cupti because some of its features involve other packages like nvperf that do not fully support CEC yet, and would therefore necessitate different pinnings in the run export. However, standalone usage of cupti is safe, so we're good with merging this PR for now and improving documentation of those edge cases over time.

@vyasr vyasr merged commit bdad9ec into conda-forge:main Mar 26, 2024
5 checks passed
@traversaro
Copy link
Contributor Author

There are some subtleties around usage of cupti because some of its features involve other packages like nvperf that do not fully support CEC yet, and would therefore necessitate different pinnings in the run export. However, standalone usage of cupti is safe, so we're good with merging this PR for now and improving documentation of those edge cases over time.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presence or absence of run_exports in cuda-cupti-dev
3 participants