Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run dependency on cuda-nvcc when using CUDA 12 #241

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Mar 27, 2024

jax has a runtime dependency on cuda-nvcc. Before CUDA 12, there was no cuda-nvcc package in conda-forge, so users had to install it in a different way (see https://github.com/google/jax/blob/jaxlib-v0.4.25/docs/installation.md#conda-installation for the jax docs on this, that suggest to install cuda-nvcc via the nvidia channel.

Since we now also have CUDA 12, the cuda-nvcc is available in conda-forge, so in the CUDA 12 case, we can just add a run dependency on it (see https://github.com/google/jax/blob/jaxlib-v0.4.25/setup.py#L132 for a similar dependency in the upstream package).

The existing build was also missing a run dependency on cuda-cupti, this will also be solved by this PR as we will build against the cuda-cupti-dev package that now has the correct run_exports (see conda-forge/cuda-cupti-feedstock#9 and conda-forge/cuda-cupti-feedstock#10).

Fix #239 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

fyi @diegoferigo @flferretti @giotherobot @lorycontixd

@xhochy
Copy link
Member

xhochy commented Mar 27, 2024

@isuruf @jaimergp Do you know what the issue with cirun.io is? Shouldn't it be OK with the global .cirun as a config.

@isuruf isuruf closed this Mar 27, 2024
@isuruf isuruf reopened this Mar 27, 2024
@isuruf
Copy link
Member

isuruf commented Mar 27, 2024

Should work now. Thanks @aktech for fixing this

@ngam
Copy link
Contributor

ngam commented Apr 4, 2024

What triggered osx-arm testing all of the sudden?

@conda-forge-admin, please rerender

@ngam
Copy link
Contributor

ngam commented Apr 4, 2024

@isuruf @xhochy I don't know if the merge should come from either of you to ensure the Cirus thing works. I think we should merge this. We will deal with the osx-arm stuff in another PR.

@xhochy
Copy link
Member

xhochy commented Apr 7, 2024

Yes, let's deal with osx-* separately.

@xhochy xhochy merged commit 044e3f9 into conda-forge:main Apr 7, 2024
19 of 43 checks passed
@traversaro
Copy link
Contributor Author

Thanks!

flferretti added a commit to ami-iit/jaxsim that referenced this pull request Apr 16, 2024
Given that conda-forge/jaxlib-feedstock#241 has been merged, they are not needed anymore
@traversaro
Copy link
Contributor Author

The existing build was also missing a run dependency on cuda-cupti, this will also be solved by this PR as we will build against the cuda-cupti-dev package that now has the correct run_exports (see conda-forge/cuda-cupti-feedstock#9 and conda-forge/cuda-cupti-feedstock#10).

This turned out not to be true, as the fix fixed 12.4.* builds, but all builds are using 12.0.* due to cuda pinned to that version. See conda-forge/cuda-cupti-feedstock#14 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add cuda-nvcc in next update
4 participants