-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename base image #8
Comments
@pelson, do you have a favored name? |
Not really. There are many running through my head ( |
I was going to say no (honestly was thing
Has the OS name, explains the compiler config, mentions 64-bit only is supported, and is versioned the same way the Thoughts? |
The only concern is the fact that a lot of implementation detail exists in the name (a bad thing rather than a good thing for me, as it means that as we change the detail, we also need to change the name). |
I guess I had the opposite view. In any event, I'm not really picky on the image name, which is why I was happy to let you pick one and still am. 😄 |
So if we don't want implementation detail in the name:
|
Just as a question, if we do ever support 32-bit, would you prefer it in a separate image or the same one? |
A question I was asking myself earlier on. In the obvious-ci image I went for "the same one". In the name proposed above I went for "a different image". |
Could you help me understand why you want to keep them separate? I could certainly see some arguments for it, but would like to here your thoughts on it. Something to consider (not that this is completely tied to this nor that this rules out having separate images either), we could select the architecture through other means. Though we may want this option in such a configuration tool no matter what we do here. |
This is simply a historically driven argument, whereby an entirely 32-bit docker image was used to produce linux-32 builds. I imagine there is detail in managing 32bit builds which would need to be handled if we were doing them on a 64bit machine (like the conda subdir / platform). I'm guessing you are asking because you do believe that we can use the same image to produce both x86 and x64 builds? |
Ah ok. Precedent mainly.
We could. That's what I did with the example image. Not saying we should or shouldn't here. Just as long as we are aware of the option. |
Was trying to think of names that fit with the forge theme (I like the creative spark and wanted to keep it alive). We could call it |
🔨 Love it. ❤️ Let's not include the arch - we can always add another image with a |
Glad you like it. 😄
Sure. Increasingly it seems 32-bit is an oddity in the Linux world. So noting it is different seems ok to me. Will make the changes now. |
Here's the PR ( #9 ) for the rename. |
Updated the PRs to |
Sounds like we don't want to call it obvious-ci. So, let's figure out what we want to call it.
The text was updated successfully, but these errors were encountered: