Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename base image #8

Closed
jakirkham opened this issue May 4, 2016 · 16 comments · Fixed by #9
Closed

Rename base image #8

jakirkham opened this issue May 4, 2016 · 16 comments · Fixed by #9

Comments

@jakirkham
Copy link
Member

Sounds like we don't want to call it obvious-ci. So, let's figure out what we want to call it.

@jakirkham
Copy link
Member Author

@pelson, do you have a favored name?

@pelson
Copy link
Member

pelson commented May 6, 2016

Not really. There are many running through my head (linux, linux-build, conda-build, linux-64) but none that really grab me. You?

@jakirkham
Copy link
Member Author

I was going to say no (honestly was thing image for a bit 😆), but this one might not be too bad.

centos_devtoolset-2_64:6

Has the OS name, explains the compiler config, mentions 64-bit only is supported, and is versioned the same way the centos image is. Not the most creative name, but it explains what it is without being too long (I hope).

Thoughts?

@pelson
Copy link
Member

pelson commented May 6, 2016

The only concern is the fact that a lot of implementation detail exists in the name (a bad thing rather than a good thing for me, as it means that as we change the detail, we also need to change the name).

@jakirkham
Copy link
Member Author

...a bad thing rather than a good thing for me...

I guess I had the opposite view.

In any event, I'm not really picky on the image name, which is why I was happy to let you pick one and still am. 😄

@pelson
Copy link
Member

pelson commented May 6, 2016

So if we don't want implementation detail in the name:

linux-build-x86_64

@jakirkham
Copy link
Member Author

Just as a question, if we do ever support 32-bit, would you prefer it in a separate image or the same one?

@pelson
Copy link
Member

pelson commented May 6, 2016

if we do ever support 32-bit, would you prefer it in a separate image or the same one?

A question I was asking myself earlier on. In the obvious-ci image I went for "the same one". In the name proposed above I went for "a different image".

@jakirkham
Copy link
Member Author

Could you help me understand why you want to keep them separate? I could certainly see some arguments for it, but would like to here your thoughts on it.

Something to consider (not that this is completely tied to this nor that this rules out having separate images either), we could select the architecture through other means. Though we may want this option in such a configuration tool no matter what we do here.

@pelson
Copy link
Member

pelson commented May 12, 2016

Could you help me understand why you want to keep them separate?

This is simply a historically driven argument, whereby an entirely 32-bit docker image was used to produce linux-32 builds. I imagine there is detail in managing 32bit builds which would need to be handled if we were doing them on a 64bit machine (like the conda subdir / platform).

I'm guessing you are asking because you do believe that we can use the same image to produce both x86 and x64 builds?

@jakirkham
Copy link
Member Author

This is simply a historically driven argument...

Ah ok. Precedent mainly.

I'm guessing you are asking because you do believe that we can use the same image to produce both x86 and x64 builds?

We could. That's what I did with the example image. Not saying we should or shouldn't here. Just as long as we are aware of the option.

@jakirkham
Copy link
Member Author

Was trying to think of names that fit with the forge theme (I like the creative spark and wanted to keep it alive). We could call it linux-anvil. Just thinking of how the anvil is used as a base while some metal is being worked. If we want to add architecture, we can do that too. Just a thought.

@pelson
Copy link
Member

pelson commented May 12, 2016

🔨 Love it. ❤️

Let's not include the arch - we can always add another image with a x86 suffix if needs be.

@jakirkham
Copy link
Member Author

Glad you like it. 😄

Let's not include the arch - we can always add another image with a x86 suffix if needs be.

Sure. Increasingly it seems 32-bit is an oddity in the Linux world. So noting it is different seems ok to me.

Will make the changes now.

@jakirkham
Copy link
Member Author

Here's the PR ( #9 ) for the rename.

@jakirkham
Copy link
Member Author

Updated the PRs to staged-recipes ( conda-forge/staged-recipes#514 ) and conda-smithy ( conda-forge/conda-smithy#151 ) to reflect the name change.

@pelson pelson closed this as completed in #9 May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants