Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add obvious-ci docker source #5

Merged
merged 1 commit into from
Apr 30, 2016

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Apr 30, 2016

@pelson, as discussed after the general meeting on the 2016-04-29, I am adding this PR to add the obvious-ci docker image here. This is being removed it from the Obvious-CI repo in this PR ( pelson/Obvious-CI#65 ). Also, will setup a Docker Hub autobuild in a moment. Already tried building this locally from this repo here and it works fine.

@jakirkham jakirkham merged commit 4ac8679 into conda-forge:master Apr 30, 2016
@jakirkham jakirkham deleted the add_obvious-ci branch April 30, 2016 20:48
@jakirkham
Copy link
Member Author

Weird. I can't create an autobuild as Docker Hub doesn't list the conda-forge organization.

@jakirkham
Copy link
Member Author

@ocefpaf, would you mind configuring this for autobuilding on DockerHub. I seem to lack sufficient privileges to do this. Once it is setup, I should be able to change the settings though.

@jakirkham jakirkham mentioned this pull request May 1, 2016
@ocefpaf
Copy link
Member

ocefpaf commented May 1, 2016

Not sure what I have to do here. Does your new powers allow you to complete this task? If not I can take a second look at this.

@jakirkham
Copy link
Member Author

I'm looking into it. Maybe.

@jakirkham
Copy link
Member Author

I don't think so. We need to enable the Docker Hub Registry for the org. Here is some info about how to do that.

@ocefpaf
Copy link
Member

ocefpaf commented May 1, 2016

I will take a look at that soon. Thanks for the info!

@ocefpaf
Copy link
Member

ocefpaf commented May 2, 2016

I cannot see that Applications section. Not sure how to proceed. I try Other things too but I must confess I either don't have the proper credentials or I have no idea what I should do (probably both 😉)

@jakirkham
Copy link
Member Author

They call it "OAuth applications" now.

@ocefpaf
Copy link
Member

ocefpaf commented May 2, 2016

I figure that out, but I should see the DockerHub request there, right? I see nothing.

@jakirkham
Copy link
Member Author

So, maybe start with this?

@ocefpaf
Copy link
Member

ocefpaf commented May 2, 2016

Humn... I thought you've done that and I should just "approve." Let me finish some things here and I will do back to it.

@jakirkham
Copy link
Member Author

It's been awhile since I have done this for an org, but I believe they send you over to GitHub, which asks you which orgs you want to setup at that point.

@jakirkham
Copy link
Member Author

Humn... I thought you've done that and I should just "approve." Let me finish some things here and I will do back to it.

Good point. I have done this now.

@jakirkham
Copy link
Member Author

It says "Access request pending" by the conda-forge org.

@jakirkham
Copy link
Member Author

Ha, I think we got it.

@ocefpaf
Copy link
Member

ocefpaf commented May 2, 2016

Good point. I have done this now.

You did not had to do it right now 😉

It says "Access request pending" by the conda-forge org.

Done!

Ha, I think we got it.

Wow you are way too fast!!!

@jakirkham
Copy link
Member Author

More like my notifications are too fast. 😆

@jakirkham
Copy link
Member Author

So, I created an autobuild on Docker Hub for obvious-ci and triggered it to run. Let's see what happens.

@jakirkham
Copy link
Member Author

Works great. Pulled down and tested.

It can be found here. The image is called condaforge/obvious-ci. I just put the build under the default tag latest. Though we may change that later. We should probably role this out across staged-recipes and add a PR to conda-smithy to change the image location to this one.

@jakirkham
Copy link
Member Author

This PR ( conda-forge/staged-recipes#514 ) switches the image used by staged-recipes to the one generated here.

This PR ( conda-forge/conda-smithy#151 ) switches the image used in conda-smithy to the one generated here.

@pelson
Copy link
Member

pelson commented May 4, 2016

Sorry, I guess I should have been more clear - I don't think we want the words "obvious-ci" anywhere in conda-forge in the long term. We should come up with an appropriate name which reflects its function.

I'm surprised you don't have exactly the same access as @ocefpaf, @jakirkham - you are both admin on the conda-forge org...

@jakirkham
Copy link
Member Author

Sorry, I guess I should have been more clear - I don't think we want the words "obvious-ci" anywhere in conda-forge in the long term. We should come up with an appropriate name which reflects its function.

Yeah, I think I missed that. I generally understood the obvious-ci code base was going away in the long term, but was missing this needed to be renamed. Opened an issue ( #8 ).

I'm surprised you don't have exactly the same access as @ocefpaf, @jakirkham - you are both admin on the conda-forge org...

Really? Yeah, weirdly, I don't. Not sure why then. Is there something I needed to do?

@jakirkham jakirkham mentioned this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants