-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switches to the org image #151
Conversation
Added some xrefs to relate this to other PRs and this move in the OP. |
982f11c
to
3024bc3
Compare
Looks like we need to rename the image before going forward on this. See this issue ( conda-forge/docker-images#8 ). |
3024bc3
to
8e17d38
Compare
Updated to reflect the proposed name change ( conda-forge/docker-images#9 ). Should hold off merging this until we have changed the name and got Docker Hub reconfigured for the change. |
The delayed nature of conda-smithy let's us off the hook a little. I will hold off on the staged-recipes one though. 😉 |
Every feedstock is now using the org image. There are no more holdouts. |
@@ -6,8 +6,7 @@ dependencies: | |||
# Note, we used to use the naive caching of docker images, but found that it was quicker | |||
# just to pull each time. #rollondockercaching | |||
override: | |||
- docker pull pelson/obvious-ci:latest_x64 | |||
# - docker pull pelson/conda32_obvious_ci | |||
- docker pull condaforge/linux-anvil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In retrospect, we should have changed this to {{ docker.image }}
, but it appears this will be resolved with PR ( #551 ).
Switches from
pelson/obvious-ci:latest_x64
tocondaforge/obvious-ci
. The source for this image is now maintained in this repo ( https://github.com/conda-forge/docker-images ). It is exactly the same source from before it is just moving to the org. In fact, the source was moved over in this PR ( conda-forge/docker-images#5 ). Similar change proposed to staged-recipes in this PR ( conda-forge/staged-recipes#514 ).