Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches to the org image #514

Merged
merged 1 commit into from
May 12, 2016
Merged

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented May 2, 2016

Depends on this PR ( conda-forge/docker-images#9 ) and some Docker Hub reconfiguration to be done first.

Switches from pelson/obvious-ci:latest_x64 to condaforge/obvious-ci condaforge/linux-anvil. The source for this image is now maintained in this repo ( https://github.com/conda-forge/docker-images ). It is exactly the same source from before it is just moving to the org. In fact, the source was moved over in this PR ( conda-forge/docker-images#5 ). Similar change proposed to conda-smithy in this PR ( conda-forge/conda-smithy#151 ).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jakirkham
Copy link
Member Author

cc @pelson @ocefpaf @jjhelmus @msarahan

@ocefpaf
Copy link
Member

ocefpaf commented May 2, 2016

@jakirkham I am 👍 to this change, but let's wait for all those you cc'ed above to answer before merging this.

@jakirkham
Copy link
Member Author

Added some xrefs to relate this to other PRs and this move in the OP.

@jakirkham
Copy link
Member Author

That's fine. I'd like to see this go into conda-smithy before we worry about it here. Just making sure we are doing the last bit of the transfer here.

@pelson
Copy link
Member

pelson commented May 4, 2016

👎 on the name. Other than that, 👍 to moving away from pelson/obvious-ci.

@jakirkham
Copy link
Member Author

👎 on the name.

Added an issue ( conda-forge/docker-images#8 ) here for that.

Other than that, 👍 to moving away from pelson/obvious-ci.

Awesome. Let's sort out the name and we can figure this out after.

@jakirkham
Copy link
Member Author

The image is going to be renamed. ( conda-forge/docker-images#9 ) Added the new proposed name here just so that we have it updated. As we haven't changed it in the org repo yet, it is failing. Will update once that has changed.

@pelson
Copy link
Member

pelson commented May 12, 2016

I'm 👍 on merging this once the image is available. No need to wait on me once this is passing the circle CI.

@pelson pelson merged commit 96153d0 into conda-forge:master May 12, 2016
@jakirkham jakirkham deleted the use_org_docker_image branch May 12, 2016 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants