-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI not uploading binaries #1
Comments
Tried bumping the build number, but no difference. The build seems to be going fine. Not sure why the upload step never happens. Is it confused because there are 2 digits in the major number? Seems like a weird thing, but it is all I can think of here. |
CircleCI token is defined in their configuration, rather than as a secret in the yaml itself. I double checked the erlang feedstock (https://circleci.com/gh/conda-forge/erlang-feedstock/edit#env-vars) and the token looks fine. The stdout from the build doesn't appear to call the upload script, although it looks to be defined correctly. |
I'm not entirely sure what is wrong with this one - the build log is quite long, but I can't imagine Circle clip the build when the log length is exceeded. Hmmm |
Yeah, it's very strange. This is sort of a lazy solution, but could we delete and try to create the feedstock again? It could have the same result, but then again maybe not. Nothing else seems to have had this issue. |
@scopatz, @pelson and I chatted about this briefly today and we are still very puzzled by this. Everything appears setup correctly on the CircleCI end. Everything else we looked at seems ok. There aren't any error messages suggesting the upload failed for some reason. We will keep this in mind. However, we likely won't have time to get to this again until Wednesday when @pelson is back. |
Ok, no worries on the timing. Thanks for looking into it. |
Going to try re-adding it as a feedstock. See this PR ( conda-forge/staged-recipes#566 ). In practice, this doesn't really change anything here (e.g. the recipe doesn't change). However, it will go back through the configuration process and so maybe it will fix something that got screwy. 💫 Then again it could do nothing. It is just something easy to try. |
Weird. That made absolutely no difference. @pelson, any other ideas we could try? |
Ugg very strange. |
Just looked at this in a bit more detail and I imagine it is related to the output being too long (which is weird). It looks like if there is too much output, the next step in the build doesn't get run. I'm experimenting in a |
That kind of solution only works for Windows 😜 Looks like it wasn't anything to do with the log length either - it still stops immediately after the build+test (https://circleci.com/gh/conda-forge/erlang-feedstock/12). I guess it could be a sigterm or something from the erlang test. Have you tried removing it? |
😆 Hardly.
I mean it just checks the version. Besides, if there was such a signal, why wouldn't that just crash |
@jakirkham - did you ever try running this on a local docker? |
Yep. There are no weird exit codes that I found. I even tried doing this ( #7 ), which seems to make no difference AFAICT. |
So, I think the last time we were looking at something related to this we were considering taking out the tests. Should we try this? |
Didn't we already test this? |
Nope. We noted we should test it after it worked somewhere else. Should be easy enough to try. |
This should be fixed by PR ( #15 ). |
Had a bit of a false start, but it seems we have fixed this issue. Linux builds are now available. As it required disabling the tests, went ahead and opened issue ( #16 ) to remind us to try and get them working again. |
Not sure why, but CircleCI is not uploading binaries here. It builds all the way through and even passes its tests. However, it does not try to upload at all.
cc @pelson
The text was updated successfully, but these errors were encountered: