-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add macos to build #9
base: main
Are you sure you want to change the base?
feat: Add macos to build #9
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
2640a82
to
1fc0ef6
Compare
So, like in conda-forge/staged-recipes#21052, the actual macOS builds are passing, but then failing given
and I don't know why, as the Linux builds are fine. For example, for the fastjet-3.4.0.6-cp312-cp312-macosx_10_13_x86_64 wheel added contents:
but then the final linking checks fail with Details:
From the Shared libraries in macOS and Linux section of the There is the section
Though I don't know what to do with this information in a conda-forge feedstock. edit: Building locally on a mac, I can see that files under % find . -type f -iname _ext.cpython-312-darwin.so
./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_ext.cpython-312-darwin.so
./miniforge3/conda-bld/fastjet_1715613590535/work/build/lib.macosx-10.9-x86_64-cpython-312/fastjet/_ext.cpython-312-darwin.so
% otool -L ./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_ext.cpython-312-darwin.so
./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_ext.cpython-312-darwin.so:
/Users/feickert/Code/GitHub/scikit-hep/conda-forge_feedstocks/fastjet-feedstock/miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjet.0.dylib (compatibility version 1.0.0, current version 1.0.0)
/Users/feickert/Code/GitHub/scikit-hep/conda-forge_feedstocks/fastjet-feedstock/miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjettools.0.dylib (compatibility version 1.0.0, current version 1.0.0)
/Users/feickert/Code/GitHub/scikit-hep/conda-forge_feedstocks/fastjet-feedstock/miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjetcontribfragile.dylib (compatibility version 0.0.0, current version 0.0.0)
@rpath/libc++.1.dylib (compatibility version 1.0.0, current version 1.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.0.0) % find . -type f -iname libfastjettools.0.dylib
./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_fastjet_core/lib/libfastjettools.0.dylib
./miniforge3/conda-bld/fastjet_1715613590535/work/build/lib.macosx-10.9-x86_64-cpython-312/fastjet/_fastjet_core/lib/libfastjettools.0.dylib
./miniforge3/conda-bld/fastjet_1715613590535/work/fastjet-core/tools/.libs/libfastjettools.0.dylib
./miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjettools.0.dylib
% otool -L ./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_fastjet_core/lib/libfastjettools.0.dylib
./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_fastjet_core/lib/libfastjettools.0.dylib:
/Users/feickert/Code/GitHub/scikit-hep/conda-forge_feedstocks/fastjet-feedstock/miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjettools.0.dylib (compatibility version 1.0.0, current version 1.0.0)
/Users/feickert/Code/GitHub/scikit-hep/conda-forge_feedstocks/fastjet-feedstock/miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjet.0.dylib (compatibility version 1.0.0, current version 1.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.0.0)
@rpath/libc++.1.dylib (compatibility version 1.0.0, current version 1.0.0) |
cwd=FASTJET, | ||
) | ||
|
||
+ # RPATH is set for shared libraries in the following locations: | ||
+ # * fastjet/ | ||
+ # * fastjet/_fastjet_core/lib/ | ||
+ # * fastjet/_fastjet_core/lib/python*/site-packages/ | ||
+ _rpath = "'$$ORIGIN/_fastjet_core/lib:$$ORIGIN:$$ORIGIN/../..'" | ||
+ if sys.platform == "darwin": | ||
+ _rpath = "'$@loader_path/_fastjet_core/lib:$@loader_path:$@loader_path/../..'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$@loader_path
doesn't work, so maybe try dropping the $
.
@conda-forge/help-python-c do you have any advice on why adding |
The issue is probably with the RPATH set in I do similar magic in https://github.com/blue-yonder/turbodbc/blob/8d73ee3a5ec6ca0c764f8910903496f513b57f57/setup.py#L100 which worked for me for the last years. |
* Bump build number.
* Using conda-forge this isn't necessary and kills the build.
* gmake is still not available for unix builds of make?
0b78fd0
to
600cbf0
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.08.13.15.51.23
Add macos to build matrix.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)