Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM OSX Migrator #34

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Conversation

xiki-tempula
Copy link
Contributor

@xiki-tempula xiki-tempula commented Nov 27, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@douglowe
Copy link
Contributor

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gromacs-feedstock/actions/runs/7008191760.

@douglowe
Copy link
Contributor

Our build problem is:

Traceback (most recent call last):
  File "/opt/conda/bin/conda-mambabuild", line 10, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 256, in main
    call_conda_build(action, config)
  File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 228, in call_conda_build
    result = api.build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/api.py", line 253, in build
    return build_tree(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 3804, in build_tree
    packages_from_this = build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2673, in build
    utils.check_call_env(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/utils.py", line 445, in check_call_env
    return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/utils.py", line 421, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['/bin/bash', '-o', 'errexit', '/home/conda/feedstock_root/build_artifacts/gromacs_1701103828945/work/conda_build.sh']' returned non-zero exit status 2.

@@ -71,7 +74,7 @@ if [[ "${BUILD_WITH_CONDA_DEBUG:-0}" == 1 ]]; then
# Drop into an interactive shell
/bin/bash
else
conda build "${RECIPE_ROOT}" -m "${CI_SUPPORT}/${CONFIG}.yaml" \
conda mambabuild "${RECIPE_ROOT}" -m "${CI_SUPPORT}/${CONFIG}.yaml" \
Copy link
Contributor

@douglowe douglowe Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest reversing this change, and see if the packages will build with conda. If they do, then we are going to have to ditch mamba for the moment.

@douglowe
Copy link
Contributor

But, on the upside - it looks like the ARM64 openmpi builds are no longer running.

Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@douglowe
Copy link
Contributor

This is all looking good to me too.

However, please can you bump the build number (meta.yaml, line 6) before this is merged?

@xiki-tempula
Copy link
Contributor Author

Sorry for the confusion. We had this pipeline problem so I just revert to the initial commit where the pipeline passes and then go one by one trying to sort things out.

@xiki-tempula
Copy link
Contributor Author

Ok, I guess the reason that build.sh is missing an fi weird that it passed before.

@xiki-tempula xiki-tempula force-pushed the bot-pr_arm_osx_h742397 branch 2 times, most recently from df8bbf9 to ec52e9c Compare November 28, 2023 10:21
@xiki-tempula
Copy link
Contributor Author

@conda-forge-admin, please rerender

@xiki-tempula
Copy link
Contributor Author

Ok, I have finally found out why the pipeline fails. I kind of based my branch on conda-forge/gromacs-feedstock:bot-pr_arm_osx_h742397 and assume that it is the same branch as the one in #30, but they are not the same branch and missed two crucial commits which is why my pipeline is always failing.

@xiki-tempula
Copy link
Contributor Author

@douglowe I think it is working now. Do you mind merge this PR, please? Thank you.

recipe/build.sh Outdated Show resolved Hide resolved
@douglowe
Copy link
Contributor

Great - it looks good to me :) I'll merge it now.

@douglowe douglowe merged commit cde675c into conda-forge:main Nov 28, 2023
16 checks passed
@xiki-tempula xiki-tempula deleted the bot-pr_arm_osx_h742397 branch November 28, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants