-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM OSX Migrator #34
ARM OSX Migrator #34
Conversation
…nda-forge-pinning 2023.11.16.09.46.51
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gromacs-feedstock/actions/runs/7008191760. |
Our build problem is:
|
@@ -71,7 +74,7 @@ if [[ "${BUILD_WITH_CONDA_DEBUG:-0}" == 1 ]]; then | |||
# Drop into an interactive shell | |||
/bin/bash | |||
else | |||
conda build "${RECIPE_ROOT}" -m "${CI_SUPPORT}/${CONFIG}.yaml" \ | |||
conda mambabuild "${RECIPE_ROOT}" -m "${CI_SUPPORT}/${CONFIG}.yaml" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest reversing this change, and see if the packages will build with conda. If they do, then we are going to have to ditch mamba for the moment.
But, on the upside - it looks like the ARM64 openmpi builds are no longer running. |
5adb1f4
to
2065620
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This is all looking good to me too. However, please can you bump the build number (meta.yaml, line 6) before this is merged? |
2065620
to
57447d9
Compare
Sorry for the confusion. We had this pipeline problem so I just revert to the initial commit where the pipeline passes and then go one by one trying to sort things out. |
57447d9
to
3079a90
Compare
Ok, I guess the reason that build.sh is missing an |
df8bbf9
to
ec52e9c
Compare
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.11.27.19.54.17
Ok, I have finally found out why the pipeline fails. I kind of based my branch on conda-forge/gromacs-feedstock:bot-pr_arm_osx_h742397 and assume that it is the same branch as the one in #30, but they are not the same branch and missed two crucial commits which is why my pipeline is always failing. |
@douglowe I think it is working now. Do you mind merge this PR, please? Thank you. |
Great - it looks good to me :) I'll merge it now. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)