Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows build and executable build #2

Merged
merged 12 commits into from
Dec 15, 2021
Merged

Conversation

mcs07
Copy link
Contributor

@mcs07 mcs07 commented Oct 23, 2019

Second attempt, using the scons build system.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mcs07
Copy link
Contributor Author

mcs07 commented Oct 23, 2019

@conda-forge-admin, please rerender

@njzjz
Copy link
Member

njzjz commented Nov 1, 2019

I think the problem has been solved. You can restart the CI.

@mcs07
Copy link
Contributor Author

mcs07 commented Nov 4, 2019

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@mcs07
Copy link
Contributor Author

mcs07 commented Nov 4, 2019

🎉

@jgullingsrud @rmcgibbo Does this look alright to you? OK to merge?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jgullingsrud jgullingsrud merged commit 6b8f643 into conda-forge:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants