Fix using wrong JPEG header by disabling OSX Frameworks #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
The lastest PR used the third party/vendored JPEG library. Now the test on OSX is also producing: |
blowekamp
force-pushed
the
OSXJPEG
branch
6 times, most recently
from
49472f5
to
6acd91d
Compare
blowekamp
changed the title
blowekamp
force-pushed
the
OSXJPEG
branch
2 times, most recently
from
7230465
to
0ae72b0
Compare
On OSX header files for JPEG, PNG, EXPAT, TIFF were being found in the Mono framework (/Library/Frameworks/Mono.framework/Headers). CMake searching in frameworks is disabled. Use CMAKE_FIND_ROOT_PATH to isolate searching to conda PREFIX.
…da-forge-pinning 2019.09.08
|
@mingwandroid I had to use some different CMake variables then what you prose. And the PROGRAM path needs to search the BUILD_PREFIX directory structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miss matching of the jpeg library is causing the following runtime
error on OSX:
Wrong JPEG library version: library is 90, caller expects 80
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)