Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] backport hotfix from tbeu/matio#92 #20

Merged
merged 2 commits into from
Aug 21, 2018

Conversation

massich
Copy link
Contributor

@massich massich commented Aug 17, 2018

This is a hotfix to backport tbeu/matio#92 while the changes are not in 1.5.12

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@massich massich changed the title [MRG] backport hotfix from #92 [MRG] backport hotfix from matio/pulls/92 Aug 17, 2018
@massich massich changed the title [MRG] backport hotfix from matio/pulls/92 [MRG] backport hotfix from tbeu/matio#92 Aug 17, 2018
@agramfort
Copy link
Contributor

@tbeu do you see any objection to merge this?

@tbeu
Copy link

tbeu commented Aug 18, 2018

Just go ahead.

@agramfort
Copy link
Contributor

I don’t have commit rights

@tbeu
Copy link

tbeu commented Aug 18, 2018

Me neither.

@agramfort
Copy link
Contributor

arfff. I guess we need to wait for @183amir

recipe/meta.yaml Outdated
@@ -7,6 +7,8 @@ source:
fn: matio-{{ version }}.tar.gz
url: https://github.com/tbeu/matio/releases/download/v{{ version }}/matio-{{ version }}.tar.gz
md5: 2968b5a95f05fab8b79ec87f9a6c0cac
patches:
- 0001-hotfix-backport-from-92.patch # [linux]

build:
number: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the build number to 1 too

@183amir
Copy link
Contributor

183amir commented Aug 18, 2018

@conda-forge-admin please rerender

@183amir
Copy link
Contributor

183amir commented Aug 18, 2018

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@183amir
Copy link
Contributor

183amir commented Aug 21, 2018

@conda-forge-admin, please rerender

@183amir 183amir merged commit 81cc8f5 into conda-forge:master Aug 21, 2018
@183amir
Copy link
Contributor

183amir commented Aug 21, 2018

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants