-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need meta-data patches for Numba/NumPy version compatibility? #90
Need meta-data patches for Numba/NumPy version compatibility? #90
Comments
Currently we have this locally: numba-feedstock/recipe/meta.yaml Lines 63 to 64 in a788925
But it wasn't there for easier versions. Is there a place to see all of the version compat info? |
In the issue they are referencing the The constraint appears to have been added in The answer is probably to hot-fix older We had explored hot-fixing older |
This is a good question and the answer was unfortunately no! I think this is a really useful thing to have and maintain as part of the release process for Numba so I've tried creating such a table based on historical The current attempt at assembling the version information can be seen rendered in: |
I just hit this bug with numba 0.53.* and numpy 1.22.* |
The PR with the docs numba/numba#7833 has been merged now so can act as a reference for constraints on the meta-data. |
So the next thing to do would be to add this as a hot-fix to the repodata. Given the oldest version covered in that table is |
hmmm I guess this is going to just require a pragmatic decision given information prior to 0.47 would require a degree of archeology :) As Numba has a reliance on NumPy and 0.47 is from two years ago, I think it would be reasonable to use that a base version for the metadata as it fits roughly with NumPy's NEP-0029. It's also the last version that supports Python 2.7 so covers that use case (though I think the percentage of Python 2.7 downloads is ~<1%). In summary, I'm of the view we should go with NumPy 1.18 unless anyone has objection/proposes something else to discuss? Also, as this is meta-data patching, I assume if there's some issue it can be patched again, albeit at the cost of having to do that! Thanks for your help @jakirkham ! |
Yes we can change the patches at any time. |
xref to tracking: numba/numba#7754 |
Hi, After reading about the issue, I am struggling to identify the next steps to fix this ? Should a PR be raised on the repodata patches, along the line of the one previously mentionned ? (conda-forge/conda-forge-repodata-patches-feedstock#51) I am willing to raise the PR, just not sure where this topic is standing at right now. |
Hello, just giving my input on this issue. As a workaround, I had to constrain Here's the related issue and PR:
Here's a snippet of the numba version compatibility table for reference: Source: https://numba.readthedocs.io/en/stable/user/installing.html#version-support-information
|
I think we need someone to add the patches now that the docs are official. |
Please see PR ( conda-forge/conda-forge-repodata-patches-feedstock#376 ) for an attempt to add these to the repodata patches |
As discussed RE TBB recently (#87 (comment)), seems like the conda-forge Numba packages might similarly need a meta-data fix to ensure that compatible NumPy builds are installed. xref bug report: numba/numba#7830
Reproducer for the invalid environment:
this resolves to using
numpy-1.22.2
locally.I'm not sure how far this issue extends with respect to Numba versions at present.
CC @jakirkham @henryiii
The text was updated successfully, but these errors were encountered: