Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] adding user @edwinnglabs #8

Merged

Conversation

conda-forge-daemon
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I've added user @edwinnglabs as instructed in #7.

Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.

Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.

Fixes #7

@edwinnglabs
Copy link
Contributor

@sugatoray

@sugatoray
Copy link
Contributor

@edwinnglabs This method adds you to the repository as a maintainer but does not show you as one on the README (since CI run is skipped). On the other hand if you add your GitHub username as a maintainer to the recipe, that takes care of everything.

@edwinnglabs
Copy link
Contributor

@edwinnglabs This method adds you to the repository as a maintainer but does not show you as one on the README (since CI run is skipped). On the other hand if you add your GitHub username as a maintainer to the recipe, that takes care of everything.

Yes. I will do that but can you merge this request first?

@edwinnglabs
Copy link
Contributor

@sugatoray it seems you still need to merge this PR. Although the recipe changed, there is a .github/CODEOWNER file change missing :(

@sugatoray
Copy link
Contributor

sugatoray commented Jan 10, 2023

Let me take a look at it later.

@edwinnglabs
Copy link
Contributor

edwinnglabs commented Jan 10, 2023

Let me take a look at it later.

Please. I'm rushing for a new version(v1.1.4) for orbit and wants to benchmark this one (v1.1.3) soon.

@sugatoray
Copy link
Contributor

Ok. Could you please fork the repo and send another PR. There was some error after the PR was merged last time. A simple new PR with the build number raised by 1 should fix this.

Please also follow the instructions in the standard PR body.

@edwinnglabs edwinnglabs merged commit fe62418 into conda-forge:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please add user @edwinnglabs
3 participants