-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove numpy 112 exclusion #2
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@kyleabeauchamp what is the minimum version of build:
numpy 1.11.*
run:
numpy >=1.11 and then re-render. If you want to support more |
I would think that anything above 1.8 would work (https://github.com/pymc-devs/pymc/blob/master/pymc-requirements#L2). Do we need to add one line for every possible numpy version or does the current recipe work. |
Nice!
For that scenario you can use exactly the combination in the recipe I sent to you above. The goal is to build with the oldest Note that we don't have |
What about numpy 1.12? That recipe doesn't list it. |
That is exactly my the point above! If you build with |
Updated with numpy grid from netcdf4 |
OK. Now you need to bump the build number, so a new package gets created, and then you'll need to rerender. See https://conda-forge.org/docs/conda_smithy.html for the instructions on re-rendering. |
I'm concerned about removing the numpy x.x. This package compiles fortran code that interacts with numpy, which to me means that we need to build a separate build for each numpy version. |
https://conda-forge.org/docs/meta.html#building-against-numpy Also, see my comment above regarding backwards ABI compatibility. |
Updated the build number, but I can't seem to get either |
That is odd. I can do that for you then. Hold on... |
@ocefpaf, can this be an issue with noarch? @kyleabeauchamp what's the version of conda-smithy you are using? (You can check by running |
|
PS: I would like to wait for @fonnesbeck to reply before we push this update live, as he is the primary maintainer of pymc. |
Don't think so, I've been using it non-stop without a problem since the release. |
Closing this in favor of #3 |
cc @fonnesbeck
I don't know if this is permissible or not. There were some reports of issues with np112 on Windows, but I'm not certain that those reports were observed on non-windows platforms.