Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy 112 exclusion #2

Closed
wants to merge 3 commits into from

Conversation

kyleabeauchamp
Copy link
Contributor

cc @fonnesbeck

I don't know if this is permissible or not. There were some reports of issues with np112 on Windows, but I'm not certain that those reports were observed on non-windows platforms.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 7, 2017

@kyleabeauchamp what is the minimum version of numpy? If it is numpy 1.11 you can do:

build:
  numpy 1.11.*
run:
  numpy >=1.11

and then re-render. If you want to support more numpy versions see https://github.com/conda-forge/netcdf4-feedstock/blob/master/recipe/meta.yaml for an example of the lower limits we have in conda-forge at the moment.

@kyleabeauchamp
Copy link
Contributor Author

I would think that anything above 1.8 would work (https://github.com/pymc-devs/pymc/blob/master/pymc-requirements#L2). Do we need to add one line for every possible numpy version or does the current recipe work.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 7, 2017

I would think that anything above 1.8 would work (https://github.com/pymc-devs/pymc/blob/master/pymc-requirements#L2).

Nice!

Do we need to add one line for every possible numpy version or does the current recipe work.

For that scenario you can use exactly the combination in the recipe I sent to you above. The goal is to build with the oldest numpy possible/available and then run with any versions that is backwards compatible.

Note that we don't have numpy 1.8 everywhere and that is why we use 1.9 or 1.11 for some Windows+Python combinations.

@kyleabeauchamp
Copy link
Contributor Author

What about numpy 1.12? That recipe doesn't list it.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 7, 2017

What about numpy 1.12? That recipe doesn't list it.

That is exactly my the point above! If you build with numpy 1.8.* and add numpy >=1..8 to run you'll be able to use any version that is >=1.8 (1.12 is >= than 1.8). Just bare in mind the caveat I mentioned above regarding the numpy versions available to build against.

@kyleabeauchamp
Copy link
Contributor Author

Updated with numpy grid from netcdf4

@ocefpaf
Copy link
Member

ocefpaf commented Sep 7, 2017

OK. Now you need to bump the build number, so a new package gets created, and then you'll need to rerender. See https://conda-forge.org/docs/conda_smithy.html for the instructions on re-rendering.

@kyleabeauchamp
Copy link
Contributor Author

I'm concerned about removing the numpy x.x. This package compiles fortran code that interacts with numpy, which to me means that we need to build a separate build for each numpy version.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 7, 2017

I'm concerned about removing the numpy x.x. This package compiles fortran code that interacts with numpy, which to me means that we need to build a separate build for each numpy version.

https://conda-forge.org/docs/meta.html#building-against-numpy

Also, see my comment above regarding backwards ABI compatibility.

@kyleabeauchamp
Copy link
Contributor Author

kyleabeauchamp commented Sep 7, 2017

Updated the build number, but I can't seem to get either conda smithy rerender or conda-smithy rerender working. Seems like the executable is not installed. I'm in the root env, FWIW.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 7, 2017

That is odd. I can do that for you then. Hold on...

@isuruf
Copy link
Member

isuruf commented Sep 7, 2017

Updated the build number, but I can't seem to get either conda smithy rerender or conda-smithy rerender working. Seems like the executable is not installed. I'm in the root env, FWIW.

@ocefpaf, can this be an issue with noarch? @kyleabeauchamp what's the version of conda-smithy you are using? (You can check by running conda list)

@kyleabeauchamp
Copy link
Contributor Author

conda list|grep smith
conda-smithy              2.4.0                      py_1    conda-forge

@kyleabeauchamp
Copy link
Contributor Author

PS: I would like to wait for @fonnesbeck to reply before we push this update live, as he is the primary maintainer of pymc.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 7, 2017

@ocefpaf, can this be an issue with noarch?

Don't think so, I've been using it non-stop without a problem since the release.

@ocefpaf ocefpaf mentioned this pull request Sep 7, 2017
@ocefpaf
Copy link
Member

ocefpaf commented Sep 7, 2017

Closing this in favor of #3

@ocefpaf ocefpaf closed this Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants